Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sidekiq] add basic Vernier spec #2465

Merged
merged 2 commits into from
Mar 12, 2025
Merged

Conversation

solnic
Copy link
Collaborator

@solnic solnic commented Nov 18, 2024

I started working on this in order to address some vernier/sidekiq issues, but these were addressed elsewhere eventually so we're left here with a spec that I wrote for vernier and sidekiq - I think it's beneficial to add it 🙂

#skip-changelog

Copy link

codecov bot commented Nov 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.05%. Comparing base (db975df) to head (5f338f1).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2465      +/-   ##
==========================================
- Coverage   64.11%   64.05%   -0.07%     
==========================================
  Files         123      123              
  Lines        4724     4713      -11     
==========================================
- Hits         3029     3019      -10     
+ Misses       1695     1694       -1     
Components Coverage Δ
sentry-ruby 59.84% <ø> (ø)
sentry-rails 59.32% <ø> (+0.10%) ⬆️
sentry-sidekiq 97.04% <ø> (-0.12%) ⬇️
sentry-resque 92.85% <ø> (ø)
sentry-delayed_job 95.65% <ø> (ø)
sentry-opentelemetry 99.31% <ø> (ø)

see 5 files with indirect coverage changes

@solnic solnic force-pushed the solnic/2457-fix-vernier-with-sidekiq branch 3 times, most recently from b1f747b to 5f338f1 Compare February 18, 2025 13:14
@solnic solnic force-pushed the solnic/2457-fix-vernier-with-sidekiq branch from 5f338f1 to 268869a Compare February 26, 2025 09:57
@solnic solnic force-pushed the solnic/2457-fix-vernier-with-sidekiq branch from 268869a to a0d0cc0 Compare March 11, 2025 13:30
@solnic solnic force-pushed the solnic/2457-fix-vernier-with-sidekiq branch from a0d0cc0 to be7f786 Compare March 11, 2025 14:17
@solnic solnic marked this pull request as ready for review March 11, 2025 15:00
@solnic solnic requested review from sl0thentr0py and st0012 March 11, 2025 15:00
@solnic solnic merged commit 0043161 into master Mar 12, 2025
136 checks passed
@solnic solnic deleted the solnic/2457-fix-vernier-with-sidekiq branch March 12, 2025 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants