fix(react-native): Replaces the deprecated enableSpotlight option with spotlight #750
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lms24
approved these changes
Dec 23, 2024
|
The E2E tests failures are definitely unrelated of the changes in this PR. |
|
Since this is a comment in the code snippet we can merge it as is, but we should drop support for RN SDK v5 and do a major only supporting RN SDK 6.x.x (not sure about the version exactly). |
|
Slightly related check for min version #752 PR with change to min 6.0.0 will follow. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes getsentry/sentry-react-native#4403
Description
Replaces the deprecated
enableSpotlightoption withspotlightin the suggestedSentry.initcomment.The option was deprecated in v6.