feature flag check

getsentry · Dec 31, 2024 · 5615ad4 · 5615ad4
1 parent 980bdeb
commit 5615ad4
Show file tree

Hide file tree

Showing 2 changed files with 50 additions and 41 deletions.
diff --git a/src/sentry/search/events/datasets/metrics.py b/src/sentry/search/events/datasets/metrics.py
@@ -5,6 +5,7 @@
 from django.utils.functional import cached_property
 from snuba_sdk import Column, Condition, Function, Op, OrderBy
 
+from sentry import features
 from sentry.api.event_search import SearchFilter
 from sentry.exceptions import IncompatibleMetricsQuery, InvalidSearchQuery
 from sentry.search.events import constants, fields
@@ -1906,30 +1907,37 @@ def _resolve_total_performance_score_function(
                         scores["inp"],
                     ],
                 ),
-                Function(
-                    "plus",
-                    [
-                        Function(
-                            "plus",
-                            [
-                                Function(
-                                    "plus",
-                                    [
-                                        Function(
-                                            "plus",
-                                            [
-                                                weights["lcp"],
-                                                weights["fcp"],
-                                            ],
-                                        ),
-                                        weights["cls"],
-                                    ],
-                                ),
-                                weights["ttfb"],
-                            ],
-                        ),
-                        weights["inp"],
-                    ],
+                (
+                    Function(
+                        "plus",
+                        [
+                            Function(
+                                "plus",
+                                [
+                                    Function(
+                                        "plus",
+                                        [
+                                            Function(
+                                                "plus",
+                                                [
+                                                    weights["lcp"],
+                                                    weights["fcp"],
+                                                ],
+                                            ),
+                                            weights["cls"],
+                                        ],
+                                    ),
+                                    weights["ttfb"],
+                                ],
+                            ),
+                            weights["inp"],
+                        ],
+                    )
+                    if features.has(
+                        "organizations:performance-vitals-handle-missing-webvitals",
+                        self.builder.params.organization,
+                    )
+                    else 1
                 ),
             ],
             alias,

diff --git a/tests/snuba/api/endpoints/test_organization_events_mep.py b/tests/snuba/api/endpoints/test_organization_events_mep.py
@@ -3125,23 +3125,24 @@ def test_total_performance_score_with_missing_vitals(self):
             tags={"transaction": "foo_transaction", "transaction.op": "pageload"},
             timestamp=self.min_ago,
         )
-        response = self.do_request(
-            {
-                "field": [
-                    "transaction",
-                    "performance_score(measurements.score.total)",
-                ],
-                "query": "",
-                "dataset": "metrics",
-                "per_page": 50,
-            }
-        )
-        assert response.status_code == 200, response.content
-        assert len(response.data["data"]) == 1
-        data = response.data["data"]
-        meta = response.data["meta"]
-        assert data[0]["performance_score(measurements.score.total)"] == 0.4
-        assert meta["isMetricsData"]
+        with self.feature({"organizations:performance-vitals-handle-missing-webvitals": True}):
+            response = self.do_request(
+                {
+                    "field": [
+                        "transaction",
+                        "performance_score(measurements.score.total)",
+                    ],
+                    "query": "",
+                    "dataset": "metrics",
+                    "per_page": 50,
+                }
+            )
+            assert response.status_code == 200, response.content
+            assert len(response.data["data"]) == 1
+            data = response.data["data"]
+            meta = response.data["meta"]
+            assert data[0]["performance_score(measurements.score.total)"] == 0.4
+            assert meta["isMetricsData"]
 
     def test_count_scores(self):
         self.store_transaction_metric(