test: Enable some easy jest eslint rules and manually fix them (#82849)

eslint.config.mjs

@@ -29,11 +29,6 @@ const restrictedImportPatterns = [
     group: ['sentry/components/devtoolbar/*'],
     message: 'Do not depend on toolbar internals',
   },
-  {
-    group: ['*.spec*'],
-    message:
-      'Do not import from test files. This causes tests to be executed multiple times.',
-  },
 ];
 
 const restrictedImportPaths = [
@@ -752,23 +747,30 @@ export default typescript.config([
     files: ['**/*.spec.{ts,js,tsx,jsx}', 'tests/js/**/*.{ts,js,tsx,jsx}'],
     plugins: jest.configs['flat/recommended'].plugins,
     rules: {
+      ...jest.configs['flat/recommended'].rules,
+      ...jest.configs['flat/style'].rules,
+
+      // `recommended` set this to warn, we've upgraded to error
       'jest/no-disabled-tests': 'error',
 
+      // `recommended` set this to warn, we've downgraded to off
       // Disabled as we have many tests which render as simple validations
       'jest/expect-expect': 'off',
 
       // Disabled as we have some comment out tests that cannot be
       // uncommented due to typescript errors.
-      'jest/no-commented-out-tests': 'off',
+      'jest/no-commented-out-tests': 'off', // TODO(ryan953): Fix violations then delete this line
 
       // Disabled as we do sometimes have conditional expects
-      'jest/no-conditional-expect': 'off',
-
-      // Useful for exporting some test utilities
-      'jest/no-export': 'off',
+      'jest/no-conditional-expect': 'off', // TODO(ryan953): Fix violations then delete this line
 
       // We don't recommend snapshots, but if there are any keep it small
       'jest/no-large-snapshots': ['error', {maxSize: 2000}],
+
+      'jest/no-alias-methods': 'off', // TODO(ryan953): Fix violations then delete this line
+      'jest/prefer-to-be': 'off', // TODO(ryan953): Fix violations then delete this line
+      'jest/prefer-to-contain': 'off', // TODO(ryan953): Fix violations then delete this line
+      'jest/prefer-to-have-length': 'off', // TODO(ryan953): Fix violations then delete this line
     },
   },
   {

static/app/components/events/contexts/knownContext/browser.spec.tsx

@@ -8,7 +8,7 @@ import {
   getBrowserContextData,
 } from 'sentry/components/events/contexts/knownContext/browser';
 
-export const MOCK_BROWSER_CONTEXT: BrowserContext = {
+const MOCK_BROWSER_CONTEXT: BrowserContext = {
   version: '83.0.4103',
   type: 'browser',
   name: '',
@@ -17,7 +17,7 @@ export const MOCK_BROWSER_CONTEXT: BrowserContext = {
   unknown_key: 123,
 };
 
-export const MOCK_REDACTION = {
+const MOCK_REDACTION = {
   name: {
     '': {
       chunks: [

static/app/components/events/contexts/platformContext/unity.spec.tsx

@@ -5,7 +5,7 @@ import {render, screen} from 'sentry-test/reactTestingLibrary';
 import ContextCard from 'sentry/components/events/contexts/contextCard';
 import {getUnityContextData} from 'sentry/components/events/contexts/platformContext/unity';
 
-export const MOCK_UNITY_CONTEXT = {
+const MOCK_UNITY_CONTEXT = {
   type: 'unity' as const,
   copy_texture_support: 'Basic, Copy3D, DifferentTypes, TextureToRT, RTToTexture',
   editor_version: '2022.1.23f1',
@@ -17,7 +17,7 @@ export const MOCK_UNITY_CONTEXT = {
   unknown_key: 123,
 };
 
-export const MOCK_REDACTION = {
+const MOCK_REDACTION = {
   install_mode: {
     '': {
       rem: [['organization:0', 'x']],

static/app/utils/profiling/profile/profile.spec.tsx

@@ -1,39 +1,8 @@
-import type {CallTreeNode} from 'sentry/utils/profiling/callTreeNode';
 import {Frame} from 'sentry/utils/profiling/frame';
 import {Profile} from 'sentry/utils/profiling/profile/profile';
 
 import {c, f, makeTestingBoilerplate} from './testUtils';
 
-// Since it's easy to make mistakes or accidentally assign parents to the wrong nodes, this utility fn
-// will format the stack samples as a tree string so it's more human friendly.
-export const _logExpectedStack = (samples: Profile['samples']): string => {
-  const head = `
-Samples follow a top-down chronological order\n\n`;
-
-  const tail = `\n
------------------------>
-stack top -> stack bottom`;
-
-  const final: string[] = [];
-
-  const visit = (node: CallTreeNode, str: string[]) => {
-    str.push(`${node.frame.name}`);
-
-    if (node.parent) {
-      visit(node.parent, str);
-    }
-  };
-
-  for (const stackTop of samples) {
-    const str = [];
-    visit(stackTop, str);
-
-    final.push(str.join(' -> '));
-  }
-
-  return `${head}${final.join('\n')}${tail}`;
-};
-
 describe('Profile', () => {
   it('Empty profile duration is not infinity', () => {
     const profile = Profile.Empty;

static/app/utils/tokenizeSearch.spec.tsx

@@ -197,7 +197,7 @@ describe('utils/tokenizeSearch', function () {
     ];
 
     for (const {name, string, object} of cases) {
-      it(name, () => expect(new MutableSearch(string)).toEqual(object));
+      it(`${name}`, () => expect(new MutableSearch(string)).toEqual(object));
     }
   });
 
@@ -504,7 +504,7 @@ describe('utils/tokenizeSearch', function () {
     ];
 
     for (const {name, string, object} of cases) {
-      it(name, () => expect(object.formatString()).toEqual(string));
+      it(`${name}`, () => expect(object.formatString()).toEqual(string));
     }
   });
 });

static/app/views/discover/table/quickContext/releaseContext.spec.tsx

@@ -12,7 +12,7 @@ import {QueryClientProvider} from 'sentry/utils/queryClient';
 import ReleaseContext from './releaseContext';
 import {defaultRow, mockedCommit, mockedUser1, mockedUser2} from './testUtils';
 
-export const mockedReleaseWithHealth = ReleaseFixture({
+const mockedReleaseWithHealth = ReleaseFixture({
   id: '1',
   shortVersion: '[email protected]',
   version: '[email protected]',

static/app/views/monitors/components/timeline/checkInTooltip.spec.tsx

@@ -14,7 +14,7 @@ type StatusCounts = [
   unknown: number,
 ];
 
-export function generateEnvMapping(name: string, counts: StatusCounts) {
+function generateEnvMapping(name: string, counts: StatusCounts) {
   const [in_progress, ok, missed, timeout, error, unknown] = counts;
   return {
     [name]: {in_progress, ok, missed, timeout, error, unknown},

static/app/views/monitors/components/timeline/utils/getAggregateStatus.spec.tsx

@@ -14,14 +14,14 @@ type StatusCounts = [
   unknown: number,
 ];
 
-export function generateEnvMapping(name: string, counts: StatusCounts) {
+function generateEnvMapping(name: string, counts: StatusCounts) {
   const [in_progress, ok, missed, timeout, error, unknown] = counts;
   return {
     [name]: {in_progress, ok, missed, timeout, error, unknown},
   };
 }
 
-export function generateStats(counts: StatusCounts) {
+function generateStats(counts: StatusCounts) {
   const [in_progress, ok, missed, timeout, error, unknown] = counts;
   return {
     in_progress,

static/app/views/monitors/components/timeline/utils/getAggregateStatusFromMultipleBuckets.spec.tsx

@@ -14,14 +14,14 @@ type StatusCounts = [
   unknown: number,
 ];
 
-export function generateEnvMapping(name: string, counts: StatusCounts) {
+function generateEnvMapping(name: string, counts: StatusCounts) {
   const [in_progress, ok, missed, timeout, error, unknown] = counts;
   return {
     [name]: {in_progress, ok, missed, timeout, error, unknown},
   };
 }
 
-export function generateStats(counts: StatusCounts) {
+function generateStats(counts: StatusCounts) {
   const [in_progress, ok, missed, timeout, error, unknown] = counts;
   return {
     in_progress,

static/app/views/monitors/components/timeline/utils/mergeBuckets.spec.tsx

@@ -13,7 +13,7 @@ type StatusCounts = [
   unknown: number,
 ];
 
-export function generateEnvMapping(name: string, counts: StatusCounts) {
+function generateEnvMapping(name: string, counts: StatusCounts) {
   const [in_progress, ok, missed, timeout, error, unknown] = counts;
   return {
     [name]: {in_progress, ok, missed, timeout, error, unknown},

static/app/views/monitors/components/timeline/utils/mergeEnvMappings.spec.tsx

@@ -14,7 +14,7 @@ type StatusCounts = [
   unknown: number,
 ];
 
-export function generateStats(counts: StatusCounts) {
+function generateStats(counts: StatusCounts) {
   const [in_progress, ok, missed, timeout, error, unknown] = counts;
   return {
     in_progress,

tests/js/setup.ts

@@ -10,6 +10,7 @@ import {ConfigFixture} from 'sentry-fixture/config';
 
 import {resetMockDate} from 'sentry-test/utils';
 
+// eslint-disable-next-line jest/no-mocks-import
 import type {Client} from 'sentry/__mocks__/api';
 // eslint-disable-next-line no-restricted-imports
 import {DEFAULT_LOCALE_DATA, setLocale} from 'sentry/locale';