Skip to content

Commit

Permalink
fix(dashboards-eap): Remove explore from widget title
Browse files Browse the repository at this point in the history
  • Loading branch information
narsaynorath committed Jan 20, 2025
1 parent abbeccb commit c362607
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 9 deletions.
16 changes: 8 additions & 8 deletions static/app/views/explore/hooks/useAddToDashboard.spec.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ describe('AddToDashboardButton', () => {
expect.objectContaining({
// For Add + Stay on Page
widget: {
title: 'Custom Explore Widget',
title: 'Custom Widget',
displayType: DisplayType.LINE,
interval: undefined,
limit: undefined,
Expand Down Expand Up @@ -72,7 +72,7 @@ describe('AddToDashboardButton', () => {
'span.duration',
'timestamp',
],
defaultTitle: 'Custom Explore Widget',
defaultTitle: 'Custom Widget',
defaultWidgetQuery:
'name=&aggregates=avg(span.duration)&columns=&fields=avg(span.duration)&conditions=&orderby=-timestamp',
displayType: DisplayType.LINE,
Expand Down Expand Up @@ -117,7 +117,7 @@ describe('AddToDashboardButton', () => {
expect.objectContaining({
// For Add + Stay on Page
widget: {
title: 'Custom Explore Widget',
title: 'Custom Widget',
displayType: DisplayType.LINE,
interval: undefined,
limit: undefined,
Expand Down Expand Up @@ -145,7 +145,7 @@ describe('AddToDashboardButton', () => {
'span.duration',
'timestamp',
],
defaultTitle: 'Custom Explore Widget',
defaultTitle: 'Custom Widget',
defaultWidgetQuery:
'name=&aggregates=max(span.duration)&columns=&fields=max(span.duration)&conditions=&orderby=-timestamp',
displayType: DisplayType.LINE,
Expand Down Expand Up @@ -178,7 +178,7 @@ describe('AddToDashboardButton', () => {
expect.objectContaining({
// For Add + Stay on Page
widget: {
title: 'Custom Explore Widget',
title: 'Custom Widget',
displayType: DisplayType.LINE,
interval: undefined,
limit: undefined,
Expand All @@ -199,7 +199,7 @@ describe('AddToDashboardButton', () => {
widgetAsQueryParams: expect.objectContaining({
dataset: WidgetType.SPANS,
defaultTableColumns: ['avg(span.duration)'],
defaultTitle: 'Custom Explore Widget',
defaultTitle: 'Custom Widget',
defaultWidgetQuery:
'name=&aggregates=avg(span.duration)&columns=&fields=avg(span.duration)&conditions=&orderby=-avg(span.duration)',
displayType: DisplayType.LINE,
Expand Down Expand Up @@ -238,7 +238,7 @@ describe('AddToDashboardButton', () => {
expect.objectContaining({
// For Add + Stay on Page
widget: {
title: 'Custom Explore Widget',
title: 'Custom Widget',
displayType: DisplayType.LINE,
interval: undefined,
limit: undefined,
Expand Down Expand Up @@ -267,7 +267,7 @@ describe('AddToDashboardButton', () => {
'max(span.duration)',
'min(span.duration)',
],
defaultTitle: 'Custom Explore Widget',
defaultTitle: 'Custom Widget',
defaultWidgetQuery:
'name=&aggregates=avg(span.duration)%2Cmax(span.duration)%2Cmin(span.duration)&columns=&fields=avg(span.duration)%2Cmax(span.duration)%2Cmin(span.duration)&conditions=&orderby=-avg(span.duration)',
displayType: DisplayType.LINE,
Expand Down
2 changes: 1 addition & 1 deletion static/app/views/explore/hooks/useAddToDashboard.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ export function useAddToDashboard() {
const search = new MutableSearch(query);

const discoverQuery: NewQuery = {
name: t('Custom Explore Widget'),
name: t('Custom Widget'),
fields,
orderby: sortBys.map(formatSort),
query: search.formatString(),
Expand Down

0 comments on commit c362607

Please sign in to comment.