Theme color direct access #105296
Open
Theme color direct access #105296
+36
−32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: jonas.badalic <[email protected]>
Contributor
|
Cursor Agent can help with this pull request. Just |
github-actions
bot
added
the
Scope: Frontend
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
static/app/views/performance/newTraceDetails/traceDrawer/details/styles.tsx
Show resolved
Hide resolved
TkDodo
reviewed
Dec 19, 2025
| aliases: Aliases | ||
| ) => ({ | ||
| tooltipUnderline: (underlineColor: ColorOrAlias = 'gray300') => ({ | ||
| tooltipUnderline: (underlineColor: ColorOrAlias | string = 'gray300') => ({ |
Collaborator
There was a problem hiding this comment.
@JonasBa there’s only a handful of usages that use tooltipUnderline with a specific color, and it’s only:
linkUnderlinegray200backgroundsuccesssuccessText,warningText,errorTextgreen300,red300,gray300
I think we should be able to find token replacements for those and just use our color tokens here?
Member
Author
There was a problem hiding this comment.
iirc there was another component that was using this, so I wanted to keep the changes small, but let me see if we can indeed one shot this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ColorOrAlias type is problematic since it creates a coupling between how the theme is structured and which colors are available. Along the same lines, organizing our theme with a flat key list isn't a scalable long term approach.
Developers should use variants to encapsulate different color meanings or access colors directly on the theme.