Skip to content

ref(alerts): Remove usage of deprecatedRouteProps for AlertRulesList route #105310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shashjar merged 1 commit into from
Dec 19, 2025
+7 −10
Merged

ref(alerts): Remove usage of deprecatedRouteProps for AlertRulesList route #105310

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion static/app/router/routes.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1480,7 +1480,6 @@ function buildRoutes(): RouteObject[] {
{
index: true,
component: make(() => import('sentry/views/alerts/list/rules/alertRulesList')),
deprecatedRouteProps: true,
},
{
path: 'details/:ruleId/',
Expand Down
16 changes: 7 additions & 9 deletions static/app/views/alerts/list/rules/alertRulesList.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,8 @@ import useRouteAnalyticsEventNames from 'sentry/utils/routeAnalytics/useRouteAna
import useRouteAnalyticsParams from 'sentry/utils/routeAnalytics/useRouteAnalyticsParams';
import useApi from 'sentry/utils/useApi';
import {useLocation} from 'sentry/utils/useLocation';
import {useNavigate} from 'sentry/utils/useNavigate';
import useOrganization from 'sentry/utils/useOrganization';
import useRouter from 'sentry/utils/useRouter';
import FilterBar from 'sentry/views/alerts/filterBar';
import AlertHeader from 'sentry/views/alerts/list/header';
import type {CombinedAlerts} from 'sentry/views/alerts/types';
Expand Down Expand Up @@ -59,9 +59,9 @@ const DataConsentBanner = HookOrDefault({
defaultComponent: null,
});

function AlertRulesList() {
export default function AlertRulesList() {
const location = useLocation();
const router = useRouter();
const navigate = useNavigate();
const api = useApi();
const queryClient = useQueryClient();
const organization = useOrganization();
Expand Down Expand Up @@ -89,7 +89,7 @@ function AlertRulesList() {

const handleChangeFilter = (activeFilters: string[]) => {
const {cursor: _cursor, page: _page, ...currentQuery} = location.query;
router.push({
navigate({
pathname: location.pathname,
query: {
...currentQuery,
Expand All @@ -100,7 +100,7 @@ function AlertRulesList() {

const handleChangeSearch = (name: string) => {
const {cursor: _cursor, page: _page, ...currentQuery} = location.query;
router.push({
navigate({
pathname: location.pathname,
query: {
...currentQuery,
Expand All @@ -111,7 +111,7 @@ function AlertRulesList() {

const handleChangeType = (alertType: CombinedAlertType[]) => {
const {cursor: _cursor, page: _page, ...currentQuery} = location.query;
router.push({
navigate({
pathname: location.pathname,
query: {
...currentQuery,
Expand Down Expand Up @@ -307,7 +307,7 @@ function AlertRulesList() {
team = '';
}

router.push({
navigate({
pathname: path,
query: {...currentQuery, team, cursor},
});
Expand All @@ -320,8 +320,6 @@ function AlertRulesList() {
);
}

export default AlertRulesList;

const StyledLoadingError = styled(LoadingError)`
grid-column: 1 / -1;
margin-bottom: ${space(4)};
Expand Down
Loading