feat(ci): monitor typescript perf #31757
Conversation
|
Got it setup and working, thanks @k-fish for help! |
| 'typescript.memory.used': {value: memoryUsage.value}, | ||
| }); | ||
|
|
||
| transaction.finish(); |
There was a problem hiding this comment.
This feel weird to me (even though I totally get it). It's a consequence of spans not being indexed, so even if the "right" solution is to have values like typescript.time.check as measurements, I feel like they should be child spans we add to the transaction. I guess part of me just wants to see the transaction waterfall with all the ts timing spans in all it's glory :)
Setting a transaction duration might be nice though! (idk if you have to adjust with performance.now())
| transaction.finish(); | |
| transaction.finish(totalTime.value); |
There was a problem hiding this comment.
@AbhiPrasad 100%, I would want each compiler step to be a span, but since we are hacking it right now, it'll have to do. I wonder if the tsc compiler exposes some hooks that we could plug into if we called it programatically. I'll investigate.
I'll add the total duration :)
There was a problem hiding this comment.
Tried adding the start/end timestamps, but couldn't get the transactions to show up in the dashboard. Sent output to @AbhiPrasad and going to merge this as is - I'm happy to add them back later :)
| @@ -0,0 +1,126 @@ | |||
| /* eslint-env node */ | |||
There was a problem hiding this comment.
We have node-ts, any reason we couldn't have written this as a typescript script?
There was a problem hiding this comment.
@evanpurkhiser I did not know we had it. I just looked at the other script in the gh folder. I'll make a PR to update it
Cant get the transaction to work and show up in Sentry correctly + there is not support for custom measurements yet. We can start by monitoring just the entire duration (timestamp - startTimestamp) and progressively add the measurements. Will need some help from SDK or someone from performance team to figure out why it's not being ingested.asked for --diagnostic clarification in microsoft/TypeScript-wiki#293