Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(insights): Query performance scores with hardcoded weights #73468

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

edwardgou-sentry
Copy link
Contributor

Updates the performance_score function in discover metrics to allow calculating total performance score with hardcoded weights. This may be useful in scenarios where certain webvitals are missing or low throughput which can cause issues when dynamically weighting vitals.

…lating total performance score with hardcoded weights
@edwardgou-sentry edwardgou-sentry requested review from a team as code owners June 27, 2024 20:45
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Jun 27, 2024
Copy link

codecov bot commented Jun 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.00%. Comparing base (fcb48c7) to head (e5873f8).
Report is 23 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #73468   +/-   ##
=======================================
  Coverage   78.00%   78.00%           
=======================================
  Files        6635     6634    -1     
  Lines      296661   296711   +50     
  Branches    51087    51097   +10     
=======================================
+ Hits       231416   231460   +44     
- Misses      58863    58868    +5     
- Partials     6382     6383    +1     
Files Coverage Δ
src/sentry/search/events/constants.py 100.00% <100.00%> (ø)
src/sentry/search/events/datasets/metrics.py 83.06% <100.00%> (+1.01%) ⬆️

... and 70 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant