feat(issue-search): support IN for semver release search #76313
+231
−104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
❌ 13 Tests Failed:
View the top 3 failed tests by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
wedamija
reviewed
Aug 17, 2024
src/sentry/search/events/filter.py
Outdated
| else: | ||
| semver_filters = [] | ||
| for v in version: | ||
| _, versions = get_versions(v, operator) |
There was a problem hiding this comment.
I'm not really sure get_versions is necessary for IN. Since in will just be doing exact matches, all the sorting junk that we do isn't really relevant.
|
This pull request has gone three weeks without activity. In another week, I will close it. But! If you comment or otherwise update it, I will reset the clock, and if you add the label "A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀 |
JoshFerge
force-pushed
the
jferg/support-in-releases
branch
from
82f152f to
a6e3bef
Compare
JoshFerge
added a commit
that referenced
this pull request
Sep 11, 2024
support `in` for for release package for issues search. related (but this one is much easier): #76313
|
This pull request has gone three weeks without activity. In another week, I will close it. But! If you comment or otherwise update it, I will reset the clock, and if you add the label "A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀 |
|
will be working on this, came up in triage duty again |
JoshFerge
force-pushed
the
jferg/support-in-releases
branch
from
486f3a2 to
99fd141
Compare
JoshFerge
commented
Oct 31, 2024
Comment on lines
+215
to
+230
| # do our best. | ||
| operator = constants.OPERATOR_NEGATION_MAP[operator] | ||
| # Note that the `order_by` here is important for index usage. Postgres seems | ||
| # to seq scan with this query if the `order_by` isn't included, so we | ||
| # include it even though we don't really care about order for this query | ||
| qs_flipped = ( | ||
| Release.objects.filter_by_semver(organization_id, parse_semver(version, operator)) | ||
| .order_by(*map(_flip_field_sort, order_by)) | ||
| .values_list("version", flat=True)[: constants.MAX_SEARCH_RELEASES] | ||
| ) | ||
|
|
||
| exclude_versions = list(qs_flipped) | ||
| if exclude_versions and len(exclude_versions) < len(versions): | ||
| # Do a negative search instead | ||
| final_operator = Op.NOT_IN | ||
| versions = exclude_versions | ||
| exclude_versions = list(qs_flipped) | ||
| if exclude_versions and len(exclude_versions) < len(versions): | ||
| # Do a negative search instead | ||
| final_operator = Op.NOT_IN | ||
| versions = exclude_versions |
There was a problem hiding this comment.
these lines are a codepath which i haven't changed, just the indentation makes it a diff, and codecov reports no coverage on these which causes the codecov to be low
wedamija
approved these changes
Nov 7, 2024
| @@ -80,16 +80,49 @@ def filter_by_semver_build( | |||
| "release_id", flat=True | |||
| ) | |||
| ) | |||
| if isinstance(build, str): | |||
There was a problem hiding this comment.
Wondering if it would make sense to just do
if isinstance(build, str):
build = [build]
Then go down the IN path
Comment on lines
+236
to
+243
| Release.objects.filter_by_semver( | ||
| organization_id, | ||
| parse_semver(v, operator), | ||
| project_ids=builder.params.project_ids, | ||
| ) | ||
| .values_list("version", flat=True) | ||
| .order_by(*order_by)[: constants.MAX_SEARCH_RELEASES] | ||
| ) |
There was a problem hiding this comment.
Since we're doing exact match here I guess we don't care about extra filtering logic in the single version branch?
There was a problem hiding this comment.
yeah, i don't think its super necessary. i'll add a comment and monitor as we release, but i think because we're only doing matches, the extra filtering logic isn't as important.
|
This pull request has gone three weeks without activity. In another week, I will close it. But! If you comment or otherwise update it, I will reset the clock, and if you add the label "A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀 |
|
Don't close this PR while remaining unmerged! We are eagerly awaiting this improvement! 😊 |
|
This pull request has gone three weeks without activity. In another week, I will close it. But! If you comment or otherwise update it, I will reset the clock, and if you add the label "A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀 |
|
Another comment to keep this open. We are eagerly waiting for this feature! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #76286
Fixes SENTRY-3HAA