ref(seer grouping): Add platform to did_call_seer metric
#80965
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found.
❌ Your patch status has failed because the patch coverage (78.57%) is below the target coverage (90.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## master #80965 +/- ##
==========================================
- Coverage 78.48% 78.47% -0.01%
==========================================
Files 7210 7208 -2
Lines 319545 319520 -25
Branches 43966 43966
==========================================
- Hits 250799 250753 -46
- Misses 62360 62372 +12
- Partials 6386 6395 +9 |
jangjodi
reviewed
Nov 19, 2024
| metrics.incr( | ||
| "grouping.similarity.did_call_seer", | ||
| sample_rate=options.get("seer.similarity.metrics_sample_rate"), | ||
| tags={"call_made": called, "blocker": blocker, "platform": event.platform}, |
There was a problem hiding this comment.
since event.platform can be None, should we make it unknown if it's None?
|
This was supplanted by #82442. Closing. |
lobsterkatie
deleted the
kmclb-include-platform-in-did_call_seer-metric
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the event's platform as a tag on the
did_call_seermetric. In order to streamline things a bit, it also adds a new helper,record_did_call_seer_metric, to make the actual datadog call. (This saves a lot of repetition of sample rate, tags, etc.)Other than the new tag, the only behavior change is that we've been (in theory) also recording
did_call_seerduring backfill, in cases where the killswitch is enabled. This is a mistake, though a harmless one as we haven't actually had to engage the killswitches in the last few months, so all our current DD data should be legit. Regardless, this fixes that, and only calls the new helper when we have an event (which we only do during ingest, not backfill).Note: Leaving this in draft because it won't typecheck until some other PRs have gone through, and in order to wait for new
did_call_seercalls to be merged, at which point I'll rebase and include them.