ref(seer grouping): Add platform
to did_call_seer
metric
#80965
+24
−45
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the event's platform as a tag on the
did_call_seer
metric. In order to streamline things a bit, it also adds a new helper,record_did_call_seer_metric
, to make the actual datadog call. (This saves a lot of repetition of sample rate, tags, etc.)Other than the new tag, the only behavior change is that we've been (in theory) also recording
did_call_seer
during backfill, in cases where the killswitch is enabled. This is a mistake, though a harmless one as we haven't actually had to engage the killswitches in the last few months, so all our current DD data should be legit. Regardless, this fixes that, and only calls the new helper when we have an event (which we only do during ingest, not backfill).Note: Leaving this in draft because it won't typecheck until some other PRs have gone through, and in order to wait for new
did_call_seer
calls to be merged, at which point I'll rebase and include them.