chore(alerts): Rm activated alerts #81095
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #81095 +/- ##
==========================================
- Coverage 78.49% 78.47% -0.02%
==========================================
Files 7215 7213 -2
Lines 319793 319553 -240
Branches 44034 44007 -27
==========================================
- Hits 251009 250781 -228
+ Misses 62399 62387 -12
Partials 6385 6385 |
This was referenced Nov 22, 2024
|
This issue has gone three weeks without activity. In another week, I will close it. But! If you comment or otherwise update it, I will reset the clock, and if you remove the label "A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀 |
|
noo leave it open I will merge this in a couple weeks |
|
This issue has gone three weeks without activity. In another week, I will close it. But! If you comment or otherwise update it, I will reset the clock, and if you remove the label "A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀 |
ceorourke
added a commit
that referenced
this pull request
Jan 6, 2025
Remove the front end for activated alerts as it's being deprecated. I can't merge this until we clean up a couple live alerts but I wanted to get the PRs ready. The gigantic backend counterpart is here #81095 **Before** <img width="1096" alt="Screenshot 2024-11-25 at 1 25 54 PM" src="https://github.com/user-attachments/assets/8d3fdbc2-59d9-4c38-9032-cf89f56e9153"> **After** <img width="1078" alt="Screenshot 2024-11-25 at 1 27 26 PM" src="https://github.com/user-attachments/assets/6d7d5191-285d-465a-9eda-a8441958e8bd">
ceorourke
added a commit
that referenced
this pull request
Jan 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feature is deprecated, we still need to remove a couple live activated alerts but I figured I'd get the removal prs ready. This is probably too big to be reviewed but if it's all in one place I can break it down into smaller ones. Front end PR to come and be merged first.