ref(issue-details): Allows replays section to reflect filters #81128
+138
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
Bundle ReportChanges will increase total bundle size by 19.35kB (0.06%) ⬆️. This is within the configured threshold ✅ Detailed changes
|
❌ 12 Tests Failed:
View the top 3 failed tests by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
leeandher
commented
Nov 21, 2024
Comment on lines
9
to
27
| export function useIssueDetailsEventCount({group}: {group: Group}) { | ||
| const eventView = useIssueDetailsEventView({group}); | ||
| const {data: groupStats} = useIssueDetailsDiscoverQuery<MultiSeriesEventsStats>({ | ||
| params: { | ||
| route: 'events-stats', | ||
| eventView, | ||
| referrer: 'issue_details.streamline_graph', | ||
| }, | ||
| }); | ||
| const eventCount = useMemo(() => { | ||
| if (!groupStats?.['count()']) { | ||
| return 0; | ||
| } | ||
| return groupStats['count()']?.data?.reduce((count, [_timestamp, countData]) => { | ||
| return count + (countData?.[0]?.count ?? 0); | ||
| }, 0); | ||
| }, [groupStats]); | ||
| return eventCount; | ||
| } |
There was a problem hiding this comment.
This kinda sucks it's the entire query for a timeseries that I iterate over to create a count.
There is definitely an easier way, but I couldn't figure out the discover syntax to get there.
|
This issue has gone three weeks without activity. In another week, I will close it. But! If you comment or otherwise update it, I will reset the clock, and if you remove the label "A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses the issue details query to ensure replays reflect the queries set above in the new UI.
Things to do: