feat(insights): register flag for wip eap #81742
Conversation
github-actions
bot
added
the
Scope: Backend
| # Make Insights modules use EAP instead of metrics, but for area's that are still WIP | ||
| manager.add("organizations:insights-use-eap-wip", OrganizationFeature, FeatureHandlerStrategy.FLAGPOLE, api_expose=True) |
There was a problem hiding this comment.
The existing "organizations:insights-use-eap" flag name really painted you into a corner for this second flag, eh? Honestly not a bad idea to replace that flag with "organizations:insights-llm-module-use-eap" but not important.
Anyway, I think "organization:insights-all-modules-use-eap" is a little better than the "-wip" prefix, since a feature flag is kind of a WIP by nature, but again, not that important.
There was a problem hiding this comment.
Thinking about this a bit more, why not use the existing feature flag? Any functionality that doesn't work on EAP won't work until it's implemented, which makes sense, right?
|
This pull request has gone three weeks without activity. In another week, I will close it. But! If you comment or otherwise update it, I will reset the clock, and if you add the label "A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀 |
Work for #81750
This PR adds a new flag,
insights-use-eap-wipCurrently we have the
insights-use-eapflag, which is used within the LLM monitoring module. This feature is enabled for a select internal devs, and internal orgs (such as sentry). LLM monitoring is feature complete with EAP, so everything works and we can enable it internally. However for modules that aren't fully supported by EAP (due to some functions that aren't available yet), we should have a separate flag so that we can have push the WIP eap+insights stuff without releasing it internally.