feat(aci): Add helpers to dual write to Actions and DataConditions

src/sentry/workflow_engine/migration_helpers/alert_rule.py

@@ -2,25 +2,157 @@
 
 from sentry.deletions.models.scheduleddeletion import RegionScheduledDeletion
 from sentry.incidents.grouptype import MetricAlertFire
-from sentry.incidents.models.alert_rule import AlertRule
+from sentry.incidents.models.alert_rule import (
+    AlertRule,
+    AlertRuleThresholdType,
+    AlertRuleTrigger,
+    AlertRuleTriggerAction,
+)
 from sentry.incidents.utils.types import DATA_SOURCE_SNUBA_QUERY_SUBSCRIPTION
+from sentry.integrations.services.integration import integration_service
 from sentry.snuba.models import QuerySubscription, SnubaQuery
 from sentry.users.services.user import RpcUser
 from sentry.workflow_engine.models import (
+    Action,
     AlertRuleDetector,
+    AlertRuleTriggerDataCondition,
     AlertRuleWorkflow,
+    DataCondition,
     DataConditionGroup,
+    DataConditionGroupAction,
     DataSource,
     Detector,
     DetectorState,
     DetectorWorkflow,
     Workflow,
+    WorkflowDataConditionGroup,
 )
+from sentry.workflow_engine.models.data_condition import Condition
 from sentry.workflow_engine.types import DetectorPriorityLevel
 
 logger = logging.getLogger(__name__)
 
 
+def get_action_type(alert_rule_trigger_action: AlertRuleTriggerAction) -> str | None:
+    if alert_rule_trigger_action.sentry_app_id:
+        return Action.Type.SENTRY_APP
+
+    elif alert_rule_trigger_action.integration_id:
+        integration = integration_service.get_integration(
+            integration_id=alert_rule_trigger_action.integration_id
+        )
+        if not integration:
+            return None
+        try:
+            return Action.Type(integration.provider)
+        except Exception:
+            return None
+    else:
+        return Action.Type.EMAIL
+
+
+def migrate_metric_action(
+    alert_rule_trigger_action: AlertRuleTriggerAction,
+) -> tuple[Action, DataConditionGroupAction] | None:
+    try:
+        alert_rule_trigger_data_condition = AlertRuleTriggerDataCondition.objects.get(
+            alert_rule_trigger=alert_rule_trigger_action.alert_rule_trigger
+        )
+    except AlertRuleTriggerDataCondition.DoesNotExist:
+        logger.exception(
+            "AlertRuleTriggerDataCondition does not exist",
+            extra={"alert_rule_trigger_id": alert_rule_trigger_action.alert_rule_trigger.id},
+        )
+        return None
+
+    action_type = get_action_type(alert_rule_trigger_action)
+    if not action_type:
+        logger.warning(
+            "Could not find a matching Action.Type for the trigger action",
+            extra={"alert_rule_trigger_action_id": alert_rule_trigger_action.id},
+        )
+        return None
+
+    data = {
+        "type": alert_rule_trigger_action.type,
+        "sentry_app_id": alert_rule_trigger_action.sentry_app_id,
+        "sentry_app_config": alert_rule_trigger_action.sentry_app_config,
+    }
+    action = Action.objects.create(
+        required=False,
+        type=action_type,
+        data=data,
+        integration_id=alert_rule_trigger_action.integration_id,
+        target_display=alert_rule_trigger_action.target_display,
+        target_identifier=alert_rule_trigger_action.target_identifier,
+        target_type=alert_rule_trigger_action.target_type,
+    )
+    data_condition_group_action = DataConditionGroupAction.objects.create(
+        condition_group_id=alert_rule_trigger_data_condition.data_condition.condition_group.id,
+        action_id=action.id,
+    )
+    return action, data_condition_group_action
+
+
+def migrate_metric_data_condition(
+    alert_rule_trigger: AlertRuleTrigger,
+) -> tuple[DataCondition, AlertRuleTriggerDataCondition] | None:
+    alert_rule = alert_rule_trigger.alert_rule
+
+    data_condition_group = DataConditionGroup.objects.create(
+        organization_id=alert_rule.organization_id
+    )
+    alert_rule_workflow = AlertRuleWorkflow.objects.get(alert_rule=alert_rule)
+    WorkflowDataConditionGroup.objects.create(
+        condition_group=data_condition_group,
+        workflow=alert_rule_workflow.workflow,
+    )
+    data_condition = DataCondition.objects.create(
+        comparison=(
+            DetectorPriorityLevel.MEDIUM
+            if alert_rule_trigger.label == "warning"
+            else DetectorPriorityLevel.HIGH
+        ),
+        condition_result=True,
+        type=Condition.ISSUE_PRIORITY_EQUALS,
+        condition_group=data_condition_group,
+    )
+    alert_rule_trigger_data_condition = AlertRuleTriggerDataCondition.objects.create(
+        alert_rule_trigger=alert_rule_trigger, data_condition=data_condition
+    )
+    return data_condition, alert_rule_trigger_data_condition
+
+
+def migrate_resolve_threshold_data_condition(alert_rule: AlertRule) -> DataCondition:
+    """
+    Create data conditions for rules with a resolve threshold
+    """
+    data_condition_group = DataConditionGroup.objects.create(
+        organization_id=alert_rule.organization_id
+    )
+    alert_rule_workflow = AlertRuleWorkflow.objects.get(alert_rule=alert_rule)
+    WorkflowDataConditionGroup.objects.create(
+        condition_group=data_condition_group,
+        workflow=alert_rule_workflow.workflow,
+    )
+    threshold_type = (
+        Condition.LESS
+        if alert_rule.threshold_type == AlertRuleThresholdType.ABOVE.value
+        else Condition.GREATER
+    )
+    # XXX: we set the resolve trigger's threshold_type to whatever the opposite of the rule's threshold_type is
+    # e.g. if the rule has a critical trigger ABOVE some number, the resolve threshold is automatically set to BELOW
+
+    data_condition = DataCondition.objects.create(
+        comparison=alert_rule.resolve_threshold,
+        condition_result=DetectorPriorityLevel.OK,
+        type=threshold_type,
+        condition_group=data_condition_group,
+    )
+    # XXX: can't make an AlertRuleTriggerDataCondition since this isn't really a trigger
+    return data_condition
+
+
 def create_metric_alert_lookup_tables(
     alert_rule: AlertRule,
     detector: Detector,
@@ -132,7 +264,7 @@ def migrate_alert_rule(
     detector_state = DetectorState.objects.create(
         detector=detector,
         active=False,
-        state=DetectorPriorityLevel.OK,
+        state=DetectorPriorityLevel.OK,  # TODO this should be determined based on whether or not the rule has an active incident
     )
     alert_rule_detector, alert_rule_workflow, detector_workflow = create_metric_alert_lookup_tables(
         alert_rule, detector, workflow

src/sentry/workflow_engine/models/action.py

@@ -29,9 +29,23 @@ class Action(DefaultFieldsModel):
     __repr__ = sane_repr("id", "type")
 
     class Type(models.TextChoices):
-        EMAIL = "email"
         SLACK = "slack"
+        MSTEAMS = "msteams"
+        DISCORD = "discord"
+
         PAGERDUTY = "pagerduty"
+        OPSGENIE = "opsgenie"
+
+        GITHUB = "github"
+        GITHUB_ENTERPRISE = "github_enterprise"
+        JIRA = "jira"
+        JIRA_SERVER = "jira_server"
+        AZURE_DEVOPS = "azure_devops"
+
+        EMAIL = "email"
+        SENTRY_APP = "sentry_app"
+
+        PLUGIN = "plugin"
         WEBHOOK = "webhook"
 
     # The type field is used to denote the type of action we want to trigger

src/sentry/workflow_engine/models/data_condition.py

@@ -36,6 +36,7 @@ class Condition(models.TextChoices):
     REGRESSION_EVENT = "regression_event"
     REAPPEARED_EVENT = "reappeared_event"
     TAGGED_EVENT = "tagged_event"
+    ISSUE_PRIORITY_EQUALS = "issue_priority_equals"
 
 
 condition_ops = {