ref(quick-start): Add task completion animation #82523
Conversation
github-actions
bot
added
the
Scope: Frontend
|
@ale-cota @evanpurkhiser what do you think of the animation? |
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #82523 +/- ##
===========================================
- Coverage 87.56% 80.50% -7.06%
===========================================
Files 9410 7304 -2106
Lines 536906 320229 -216677
Branches 21118 20882 -236
===========================================
- Hits 470131 257806 -212325
+ Misses 66409 62017 -4392
- Partials 366 406 +40 |
|
Feels a bit slow |
| /** | ||
| * How long (in ms) to delay before beginning to mark tasks complete | ||
| */ | ||
| const INITIAL_MARK_COMPLETE_TIMEOUT = 600; |
There was a problem hiding this comment.
nit: Should we maybe make this smaller, it seems pretty slow in the video you have shared, i am not sure if users will wait and keep attention that long at the tasks list?
There was a problem hiding this comment.
yes the same feedback I got from Evan... I will set 450 and see if it improves
There was a problem hiding this comment.
I think the speed of the animation itself also feels slow. Like the actual motion. I would expect them to switch around a bit snappier. We had animation on these before right?
There was a problem hiding this comment.
yes we did have but I find the animation not very smooth/natural. do you prefer that?
Screen.Recording.2024-12-23.at.16.34.03.mov
There was a problem hiding this comment.
I actually think this feels better. Snappier animation generally makes the app feel a little bit "faster" if that makes sense
| .map(task => task.task); | ||
|
|
||
| for (const task of unseenTasks) { | ||
| updateOnboardingTask(api, organization, {task, completionSeen: true}); |
There was a problem hiding this comment.
is there no way to have only 1 api call?
There was a problem hiding this comment.
no we have to update the backend
|
@evanpurkhiser I applied your feedback and updated the animation to be snappier for now. We're discussing this internally, so I might need to make further changes in another PR. Let's see 🙂 |
…etsentry/sentry into priscila/ref/quick-start/add-animation
Bundle ReportChanges will increase total bundle size by 524 bytes (0.0%) ⬆️. This is within the configured threshold ✅ Detailed changes
|
…etsentry/sentry into priscila/ref/quick-start/add-animation
closes https://github.com/getsentry/projects/issues/337
Preview
Screen.Recording.2024-12-23.at.15.54.57.mov
Note
Maybe we want to add a delay when skipping the last task in the group? 🤔