ref(issue-views): Fold navigate behavior into issueViews context #82540
+114
−110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
malwilley
approved these changes
Dec 26, 2024
| if (action.type === 'SYNC_VIEWS_TO_BACKEND' || action.syncViews) { | ||
| debounceUpdateViews(newState.views); | ||
| } | ||
|
|
||
| if (action.updateQueryParams) { | ||
| queueMicrotask(() => { |
There was a problem hiding this comment.
Is this queueMicrotask necessary?
There was a problem hiding this comment.
This seemed to fix an error that would occur in tests (something about not being able to simultaneously update state in two components at once), though that never seemed to be an issue in the UI.
andrewshie-sentry
pushed a commit
that referenced
this pull request
Jan 2, 2025
) This PR refactors the issue views family of components by moving lots of the navigation logic into the IssueViews context created in [this PR](#82429). Many of the tab actions that were folded into the IssueViews context require changes to the query parameters, which is why it makes sense to combine these two actions in the reducer function. For example: * Duplicating a tab requires the newly created tab to be selected (change viewId parameter) * Discarding a tab's changes requires the query/sort to be reset to the original query/sort (change query/sort param
|
PR reverted: 520e316 |
getsentry-bot
added a commit
that referenced
this pull request
Jan 3, 2025
…ext (#82540)" This reverts commit 518b63d. Co-authored-by: malwilley <[email protected]>
|
@MichaelSun48 reverting because we noticed a bug with this change:
This would often cause the issue stream to lock up or not navigate back at all |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the issue views family of components by moving lots of the navigation logic into the IssueViews context created in this PR.
Many of the tab actions that were folded into the IssueViews context require changes to the query parameters, which is why it makes sense to combine these two actions in the reducer function. For example: