Account Notification Settings Input Issues (UI only) #82642
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
False as a value in dropdown was causing unexpected behaviour
github-actions
bot
added
the
Scope: Frontend
nipunh
changed the title
ryan953
added
the
Trigger: getsentry tests
ryan953
approved these changes
Dec 31, 2024
|
Hi @nipunh, awesome fix! Thanks for tagging us too. I think we didn't see the PR right away away because there's no codeowners for this file/folder. So no one got an automatic notification. I'll fix that up now too so the next one hits my inbox right away. |
|
Fixes #82508 |
Thank you for the response, I have worked on another one #82641 . Can you please also review it and let me know if any further changes are required. |
andrewshie-sentry
pushed a commit
that referenced
this pull request
Jan 2, 2025
False as a value in dropdown was causing unexpected behaviour <!-- Describe your PR here. --> Solves this issue : #82508 Changed checks, The setting "Off" was internally represented with the value False, but the front-end logic did not properly handle this case. Earlier : When selected value is Off text field shows "--"   After Change  <!-- Sentry employees and contractors can delete or ignore the following. --> ### Legal Boilerplate Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
False as a value in dropdown was causing unexpected behaviour
Solves this issue : #82508
Changed checks, The setting "Off" was internally represented with the value False, but the front-end logic did not properly handle this case.
Earlier : When selected value is Off text field shows "--"
After Change
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.