🔧 chore: remove redundant slack logging & metrics #82744
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
cathteng
approved these changes
Dec 31, 2024
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## master #82744 +/- ##
==========================================
+ Coverage 87.49% 87.50% +0.01%
==========================================
Files 9410 9410
Lines 536849 536816 -33
Branches 21049 21049
==========================================
+ Hits 469704 469731 +27
+ Misses 66776 66716 -60
Partials 369 369 |
iamrajjoshi
force-pushed
the
raj/clean-slack-slo-logging-1
branch
from
ed76963 to
3eb0398
Compare
iamrajjoshi
commented
Jan 3, 2025
| thread_ts=parent_notification.message_identifier, | ||
| text=notification_to_send, | ||
| blocks=json_blocks, | ||
| ) |
There was a problem hiding this comment.
diff is weird here, but basically we don't catch the SlackAPI in this function, rather the callee function above.
iamrajjoshi
commented
Jan 3, 2025
| client=slack_client, | ||
| ) | ||
| except Exception as err: | ||
| if isinstance(err, SlackApiError): |
There was a problem hiding this comment.
taking care of the lifecycle here instead
GabeVillalobos
approved these changes
Jan 3, 2025
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we have completed the audit of our integration slos, so going back and cleaning up redundant logging and metrics.
we should also monitor our DD monitors to see if they need updating.