Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔧 chore: GA slack multi team linking #82746

Merged
merged 3 commits into from
Dec 31, 2024

Conversation

iamrajjoshi
Copy link
Member

Slack multi team single channel linking has been GA'ed for a while and i was able to track down the bug in the sentry workspace to something unrelated so cleaning up the code now. will have a follow up pr in options, then a final one here to remove the handler.

I need to do it this way cause customers will have a disruption when trying to link/unlink if i don't set the default first.

oh also, we can remove an slo reason with this feature add.

@iamrajjoshi iamrajjoshi self-assigned this Dec 31, 2024
@iamrajjoshi iamrajjoshi requested review from a team as code owners December 31, 2024 00:34
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Dec 31, 2024
Copy link

codecov bot commented Dec 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #82746      +/-   ##
==========================================
+ Coverage   87.39%   87.49%   +0.10%     
==========================================
  Files        9409     9409              
  Lines      538560   538530      -30     
  Branches    21037    21034       -3     
==========================================
+ Hits       470691   471212     +521     
+ Misses      67498    66947     -551     
  Partials      371      371              

@iamrajjoshi iamrajjoshi merged commit d23829a into master Dec 31, 2024
49 checks passed
@iamrajjoshi iamrajjoshi deleted the raj/ga-slack-multi-team-linking branch December 31, 2024 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants