fix(dashboards): Left alignment for edit access in table view #82858
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #82858 +/- ##
==========================================
- Coverage 87.50% 87.50% -0.01%
==========================================
Files 9407 9407
Lines 536681 536679 -2
Branches 21045 21045
==========================================
- Hits 469627 469625 -2
Misses 66686 66686
Partials 368 368 |
narsaynorath
approved these changes
Jan 3, 2025
| @@ -339,10 +346,11 @@ const StyledFeatureBadge = styled(FeatureBadge)` | |||
| margin-right: 6px; | |||
| `; | |||
|
|
|||
| const StyledBadge = styled(Badge)<{size: number}>` | |||
| const StyledBadge = styled(Badge)<{listonly: string; size: number}>` | |||
There was a problem hiding this comment.
I think you can make listonly a boolean? Also makes the ternary condition on lines 339 and 340 easier to use and you won't have to call toString
There was a problem hiding this comment.
i did that initially and it was giving me some really dumb errors so just changed it to this 😞
nikkikapadia
deleted the
nikki/fix/dashboards-table-view-access-padding
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before rolling out I wanted to fix this small alignment issue that Vasudha brought up. We wanted the access column to have the same alignment as the rest of the columns. Before and after below :)
(access column is properly left aligned)