Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(insights): update total opportunity score function to handle missing vitals #82923

Merged

Conversation

edwardgou-sentry
Copy link
Contributor

@edwardgou-sentry edwardgou-sentry commented Jan 6, 2025

Updates total opportunity score function to upscale if there are any missing webvitals score. Consolidates the total weight logic in performance and opportunity scores into a single _resolve_total_weights_function function.

Similar to #82750

@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Jan 6, 2025
@edwardgou-sentry edwardgou-sentry marked this pull request as ready for review January 6, 2025 16:14
@edwardgou-sentry edwardgou-sentry requested a review from a team as a code owner January 6, 2025 16:14
@edwardgou-sentry edwardgou-sentry merged commit 28bd8e7 into master Jan 6, 2025
50 checks passed
@edwardgou-sentry edwardgou-sentry deleted the egou/feat/opportunity-score-handle-missing-vitals branch January 6, 2025 19:48
@github-actions github-actions bot locked and limited conversation to collaborators Jan 22, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants