feat(workflow-engine): add AssignedToConditionHandler
#82956
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
cathteng
approved these changes
Jan 6, 2025
Comment on lines
36
to
38
| for assignee in assignees: | ||
| if assignee.team and assignee.team_id == target_id: | ||
| return True |
There was a problem hiding this comment.
i think we could refactor this slightly
Suggested change
| for assignee in assignees: | |
| if assignee.team and assignee.team_id == target_id: | |
| return True | |
| return any(assignee.team and assignee.team_id == target_id for assignee in assignees) |
and similarly for the chunk below
| assignee_list: Sequence[GroupAssignee] | None = cache.get(cache_key) | ||
| if assignee_list is None: | ||
| assignee_list = list(group.assignee_set.all()) | ||
| cache.set(cache_key, assignee_list, 60) |
There was a problem hiding this comment.
is 60 in seconds? is that a bit short 🤔
There was a problem hiding this comment.
the original PR doesn't have much context 😭 oh well. at least we're keeping it the same
ameliahsu
force-pushed
the
mia/aci/assigned-to
branch
from
634b579 to
f59c16a
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #82956 +/- ##
===========================================
+ Coverage 45.27% 87.56% +42.29%
===========================================
Files 9407 9423 +16
Lines 535958 536696 +738
Branches 21119 21106 -13
===========================================
+ Hits 242632 469965 +227333
+ Misses 292966 66366 -226600
- Partials 360 365 +5 |
andrewshie-sentry
pushed a commit
that referenced
this pull request
Jan 22, 2025
add `AssignedToConditionHandler`
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add
AssignedToConditionHandler