-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(insights): Opportunity score fixes #82967
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
edwardgou-sentry
commented
Jan 6, 2025
•
edited
Loading
edited
- Updates opportunity score function to forward query filter to secondary helper query
- Updates opportunity score to determine total weight by checking sum weight measurement instead of count
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #82967 +/- ##
==========================================
+ Coverage 87.56% 87.57% +0.01%
==========================================
Files 9409 9410 +1
Lines 536869 536907 +38
Branches 21107 21107
==========================================
+ Hits 470084 470179 +95
+ Misses 66419 66362 -57
Partials 366 366 |
gggritso
approved these changes
Jan 7, 2025
PR reverted: 6789c37 |
getsentry-bot
added a commit
that referenced
this pull request
Jan 7, 2025
This reverts commit 817ebb0. Co-authored-by: edwardgou-sentry <[email protected]>
Needed to revert this since this causes the helper query to have a |
andrewshie-sentry
pushed a commit
that referenced
this pull request
Jan 22, 2025
- Updates opportunity score function to forward query filter to secondary helper query - Updates opportunity score to determine total weight by checking sum weight measurement instead of count
andrewshie-sentry
pushed a commit
that referenced
this pull request
Jan 22, 2025
This reverts commit 817ebb0. Co-authored-by: edwardgou-sentry <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Scope: Backend
Automatically applied to PRs that change backend components
Trigger: Revert
Add to a merged PR to revert it (skips CI)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.