Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(insights): Opportunity score fixes #82967

Merged
merged 2 commits into from
Jan 7, 2025

Conversation

edwardgou-sentry
Copy link
Contributor

@edwardgou-sentry edwardgou-sentry commented Jan 6, 2025

  • Updates opportunity score function to forward query filter to secondary helper query
  • Updates opportunity score to determine total weight by checking sum weight measurement instead of count

@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Jan 6, 2025
Copy link

codecov bot commented Jan 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #82967      +/-   ##
==========================================
+ Coverage   87.56%   87.57%   +0.01%     
==========================================
  Files        9409     9410       +1     
  Lines      536869   536907      +38     
  Branches    21107    21107              
==========================================
+ Hits       470084   470179      +95     
+ Misses      66419    66362      -57     
  Partials      366      366              

@edwardgou-sentry edwardgou-sentry changed the title fix(insights): check sum weight instead fix(insights): Opportunity score fixes Jan 6, 2025
@edwardgou-sentry edwardgou-sentry marked this pull request as ready for review January 6, 2025 23:36
@edwardgou-sentry edwardgou-sentry requested a review from a team as a code owner January 6, 2025 23:36
@edwardgou-sentry edwardgou-sentry merged commit 817ebb0 into master Jan 7, 2025
51 checks passed
@edwardgou-sentry edwardgou-sentry deleted the egou/fix/perf-score-weight branch January 7, 2025 15:01
@edwardgou-sentry edwardgou-sentry added the Trigger: Revert Add to a merged PR to revert it (skips CI) label Jan 7, 2025
@getsentry-bot
Copy link
Contributor

PR reverted: 6789c37

getsentry-bot added a commit that referenced this pull request Jan 7, 2025
This reverts commit 817ebb0.

Co-authored-by: edwardgou-sentry <[email protected]>
@edwardgou-sentry
Copy link
Contributor Author

Needed to revert this since this causes the helper query to have a having condition, which triggers and edge case error in the query builder. I'll have a follow up PR to work around this edge case and reopen

andrewshie-sentry pushed a commit that referenced this pull request Jan 22, 2025
- Updates opportunity score function to forward query filter to
secondary helper query
- Updates opportunity score to determine total weight by checking sum
weight measurement instead of count
andrewshie-sentry pushed a commit that referenced this pull request Jan 22, 2025
This reverts commit 817ebb0.

Co-authored-by: edwardgou-sentry <[email protected]>
@github-actions github-actions bot locked and limited conversation to collaborators Jan 23, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Backend Automatically applied to PRs that change backend components Trigger: Revert Add to a merged PR to revert it (skips CI)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants