chore(workfow-engine): split condition handlers into separate files #82970
Conversation
github-actions
bot
added
the
Scope: Backend
| event = job["event"] | ||
| first_seen = event.group.first_seen | ||
| current_time = timezone.now() | ||
| comparison_type = comparison.get("comparison_type") |
There was a problem hiding this comment.
@cathteng @ameliahsu 🤔 thoughts on how we could add type safety to these? i think this is fine for now, but i wonder if we could improve this system a bit.
One idea I had was to add another generic type on the condition handler, then pass it through to evaluate value (the same way we are for the first parameter in evaluate value).
Any ideas on how we could do that with json schema or anything? 🤔
There was a problem hiding this comment.
i was thinking of validation on the comparison using a dataclass with types given the DataCondition.type with a registry storing the dataclasses. this would be more robust than json schema because you can use a list of possible values for a single key, whereas json schema is limited to the basic types
There was a problem hiding this comment.
basically spreading the comparison dict into the dataclass to check that the contents we need are there and are the correct type
…82970) split condition handlers into their own files since the shared files were getting kinda long
split condition handlers into their own files since the shared files were getting kinda long