feat(metric-issues): Add detector details to sidebar #82972
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
snigdhas
commented
Jan 6, 2025
snigdhas
commented
github-actions
bot
added
the
Scope: Frontend
roggenkemper
reviewed
Jan 7, 2025
scttcper
reviewed
Jan 7, 2025
static/app/views/issueDetails/streamline/sidebar/metricIssueSidebarSection.tsx
Show resolved
Hide resolved
roggenkemper
reviewed
Jan 7, 2025
| @@ -89,6 +90,10 @@ export default function StreamlinedSidebar({group, event, project}: Props) { | |||
| <MergedIssuesSidebarSection /> | |||
| </Fragment> | |||
| )} | |||
| <Fragment> | |||
| <StyledBreak /> | |||
There was a problem hiding this comment.
this adds an extra line under Merged Issues even if the sidebar section doesn't appear
There was a problem hiding this comment.
added a check for the alert_rule_id field
roggenkemper
approved these changes
Jan 8, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.