chore(sentry apps): Use new error design for token exchange process #83450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
Christinarlong
changed the base branch from
master
to
crl/new-sa-error-w-fixes
Christinarlong
commented
Jan 15, 2025
cathteng
reviewed
Jan 16, 2025
src/sentry/sentry_apps/api/endpoints/sentry_app_authorizations.py
Outdated
Show resolved
Hide resolved
src/sentry/sentry_apps/api/endpoints/sentry_app_authorizations.py
Outdated
Show resolved
Hide resolved
cathteng
reviewed
Jan 21, 2025
iamrajjoshi
reviewed
Jan 22, 2025
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## master #83450 +/- ##
==========================================
+ Coverage 85.64% 87.83% +2.18%
==========================================
Files 9498 9527 +29
Lines 541790 559738 +17948
Branches 21242 21242
==========================================
+ Hits 464040 491649 +27609
+ Misses 77385 67724 -9661
Partials 365 365 |
iamrajjoshi
reviewed
Jan 24, 2025
| raise SentryAppSentryError( | ||
| "Could not find application from grant", | ||
| status_code=401, | ||
| webhook_context={"code": self.code[:4], "grant_id": self.grant.id}, |
There was a problem hiding this comment.
xtreme nit: magic # to a constant
iamrajjoshi
approved these changes
Jan 27, 2025
andrewshie-sentry
pushed a commit
that referenced
this pull request
Jan 29, 2025
c298lee
pushed a commit
that referenced
this pull request
Jan 29, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relies on #83355 / I branched off of that PR
PLEASE LET ME KNOW IF ANYTHING IS SENSITIVE OR SUS INFO that can't be shared
(This is especially true due to this being the oauth process modules)