Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref(dashboards): Simplify WidgetCardChart #83535

Merged
merged 5 commits into from
Jan 20, 2025

Conversation

gggritso
Copy link
Member

Moving some code around, in preparation to integrate standards widgets.

  • Move error handling higher up. Instead of having a bunch of error panels everywhere, check once at the top of the render method
  • Move series colorization higher in the component. Moves the code up to reduce nesting, and makes it easier to return early if needed
  • Resolve duplication of JSX. Instead of a conditional, pass enabled to ReleaseQueries to prevent unnecessarily loading data

@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Jan 15, 2025
@gggritso gggritso marked this pull request as ready for review January 16, 2025 01:16
@gggritso gggritso requested a review from a team as a code owner January 16, 2025 01:16
@gggritso gggritso merged commit abbeccb into master Jan 20, 2025
42 checks passed
@gggritso gggritso deleted the ref/dashboards/simplify-widget-card-chart branch January 20, 2025 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants