c #83628
Closed
c #83628
+5
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## master #83628 +/- ##
=======================================
Coverage 87.57% 87.58%
=======================================
Files 9492 9492
Lines 539110 539111 +1
Branches 21218 21218
=======================================
+ Hits 472116 472163 +47
+ Misses 66645 66599 -46
Partials 349 349 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Corrects #83566
When Snuba sends back
AttributeValueofTYPE_DOUBLEandval_double, Sentry usesTYPE_MAPto resolve the column intoTYPE_FLOATfor doubles, and will try to readval_float. This is unintended behavior.There are 2 approaches: