-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
fix(auto_source_config): Pass group_id to avoid Snuba call #83650
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
armenzg
merged 11 commits into
master
from
do_not_call_snuba/auto_source_config/armenzg
Jan 20, 2025
Merged
Changes from 8 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
22a9f23
fix(auto_source_config): Pass group_id to avoid Snuba call
armenzg 31c724f
Add kwargs back
armenzg a3053c3
Fix
armenzg fb34b0d
Merge branch 'master' into do_not_call_snuba/auto_source_config/armenzg
armenzg eb830a0
Merge branch 'master' into do_not_call_snuba/auto_source_config/armenzg
armenzg 9d1bc27
Make it optional
armenzg 529d8f6
Handle group_id being None
armenzg 461d929
Fix
armenzg 1d02365
Revert order
armenzg 5ab7e4f
Merge branch 'master' into do_not_call_snuba/auto_source_config/armenzg
armenzg 8416de5
Merge branch 'master' into do_not_call_snuba/auto_source_config/armenzg
armenzg File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -1017,7 +1017,7 @@ def process_code_mappings(job: PostProcessJob) -> None: | |
else: | ||
return | ||
|
||
auto_source_code_config.delay(project.id, event_id=event.event_id) | ||
auto_source_code_config.delay(project.id, event_id=event.event_id, group_id=group_id) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Just make sure that the |
||
|
||
except Exception: | ||
logger.exception("Failed to process automatic source code config") | ||
|
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do you have to access it using
kwargs["group_id"]
too? or is making it optional in the signature enough?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let us not find out the wrong way.
I have changed it to
None
by default.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's fine to have it in the signature with
= None