Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(auto_source_code): Drop old queue #83667

Merged
merged 1 commit into from
Jan 20, 2025
Merged

chore(auto_source_code): Drop old queue #83667

merged 1 commit into from
Jan 20, 2025

Conversation

armenzg
Copy link
Member

@armenzg armenzg commented Jan 17, 2025

This reverts commit fae6fd3 which got reverted in #83640.

It was reverted because I made the mistake of removing the option before this was fully out.

@armenzg armenzg self-assigned this Jan 17, 2025
@armenzg armenzg requested a review from a team as a code owner January 17, 2025 19:23
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Jan 17, 2025
@codecov Codecov
Copy link

codecov bot commented Jan 17, 2025

Codecov Report

Attention: Patch coverage is 98.61111% with 1 line in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/sentry/tasks/post_process.py 66.66% 1 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##           master   #83667   +/-   ##
=======================================
  Coverage   87.57%   87.58%           
=======================================
  Files        9492     9492           
  Lines      539335   539321   -14     
  Branches    21221    21221           
=======================================
- Hits       472349   472341    -8     
+ Misses      66637    66631    -6     
  Partials      349      349

@armenzg
Copy link
Member Author

armenzg commented Jan 20, 2025

I have deployed another option to change the setting for all regions:
https://github.com/getsentry/sentry-options-automator/pull/3020

The queue is not used anymore, thus, it is now safe to merge this.
image

@armenzg armenzg merged commit 3932ce0 into master Jan 20, 2025
50 checks passed
@armenzg armenzg deleted the drop_queue/armenzg branch January 20, 2025 15:26
@armenzg armenzg changed the title Revert "Revert "chore(auto_source_code): Drop old queue (#83640)"" chore(auto_source_code): Drop old queue Jan 20, 2025
@armenzg armenzg mentioned this pull request Jan 20, 2025
Closed
andrewshie-sentry pushed a commit that referenced this pull request Jan 22, 2025
@armenzg @andrewshie-sentry
Revert "Revert "chore(auto_source_code): Drop old queue (#83640)"" (#…
f8c32e3 
…83667)

This reverts commit fae6fd3 which got
reverted in #83640.

It was reverted because I made the mistake of removing the option before
this was fully out.
@github-actions github-actions bot locked and limited conversation to collaborators Feb 5, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JoshFerge JoshFerge JoshFerge approved these changes

Assignees

@armenzg armenzg

Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@armenzg @JoshFerge