Skip to content

ref(py): Move {org -> organization}_auth_tokens #83677

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 17, 2025
Merged

ref(py): Move {org -> organization}_auth_tokens #83677

merged 1 commit into from
Jan 17, 2025

Conversation

evanpurkhiser
Copy link
Member

No description provided.

@evanpurkhiser evanpurkhiser requested a review from a team as a code owner January 17, 2025 20:38
@evanpurkhiser evanpurkhiser requested review from a team and removed request for a team January 17, 2025 20:38
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Jan 17, 2025
@evanpurkhiser evanpurkhiser enabled auto-merge (squash) January 17, 2025 20:51
@codecov Codecov
Copy link

codecov bot commented Jan 17, 2025 •
edited
Loading

❌ 3 Tests Failed:

Tests completed Failed Passed Skipped
5788 3 5785 141
View the top 3 failed tests by shortest run time 
tests.sentry.api.endpoints.test_organization_auth_tokens.OrganizationAuthTokensPermissionTest::test_owner_can_get
Stack Traces | 3.37s run time 
#x1B[1m#x1B[.../api/endpoints/test_organization_auth_tokens.py#x1B[0m:199: in test_owner_can_get
    self.assert_owner_can_access(self.path)
#x1B[1m#x1B[.../sentry/testutils/cases.py#x1B[0m:954: in assert_owner_can_access
    return self.assert_role_can_access(path, "owner", **kwargs)
#x1B[1m#x1B[.../sentry/testutils/cases.py#x1B[0m:960: in assert_role_can_access
    return self.assert_can_access(user, path, **kwargs)
#x1B[1m#x1B[.../sentry/testutils/cases.py#x1B[0m:926: in assert_can_access
    resp = getattr(self.client, method.lower())(path, **kwargs)
#x1B[1m#x1B[31m.venv/lib/python3.13.../django/test/client.py#x1B[0m:1129: in get
    response = super().get(
#x1B[1m#x1B[31m.venv/lib/python3.13.../django/test/client.py#x1B[0m:479: in get
    return self.generic(
#x1B[1m#x1B[31m.venv/lib/python3.13.../django/test/client.py#x1B[0m:676: in generic
    return self.request(**r)
#x1B[1m#x1B[31m.venv/lib/python3.13.../django/test/client.py#x1B[0m:1092: in request
    self.check_exception(response)
#x1B[1m#x1B[31m.venv/lib/python3.13.../django/test/client.py#x1B[0m:805: in check_exception
    raise exc_value
#x1B[1m#x1B[31m.venv/lib/python3.13.../core/handlers/exception.py#x1B[0m:55: in inner
    response = get_response(request)
#x1B[1m#x1B[31m.venv/lib/python3.13.../core/handlers/base.py#x1B[0m:197: in _get_response
    response = wrapped_callback(request, *callback_args, **callback_kwargs)
#x1B[1m#x1B[31m.venv/lib/python3.13.../views/decorators/csrf.py#x1B[0m:65: in _view_wrapper
    return view_func(request, *args, **kwargs)
#x1B[1m#x1B[31m.venv/lib/python3.13.../views/generic/base.py#x1B[0m:104: in view
    return self.dispatch(request, *args, **kwargs)
#x1B[1m#x1B[.../sentry/silo/base.py#x1B[0m:158: in override
    return original_method(*args, **kwargs)
#x1B[1m#x1B[31m.venv/lib/python3.13.../views/decorators/csrf.py#x1B[0m:65: in _view_wrapper
    return view_func(request, *args, **kwargs)
#x1B[1m#x1B[.../sentry/api/base.py#x1B[0m:119: in allow_cors_options_wrapper
    response = func(self, request, *args, **kwargs)
#x1B[1m#x1B[.../sentry/api/base.py#x1B[0m:473: in dispatch
    raise MissingPaginationError(handler.__func__.__qualname__)
#x1B[1m#x1B[31mE   sentry.api.paginator.MissingPaginationError: Response is not paginated correctly in OrganizationAuthTokensEndpoint.get.#x1B[0m
#x1B[1m#x1B[31mE                       List API response should be paginated, as lack of pagination can break the product in the future due to eventual growth.#x1B[0m
#x1B[1m#x1B[31mE                       Learn more about pagination in https://develop.sentry.dev/api/concepts/#paginating-responses and reach out to #discuss-api if you have any questions.#x1B[0m
tests.sentry.api.endpoints.test_organization_auth_tokens.OrganizationAuthTokensPermissionTest::test_manager_can_get
Stack Traces | 3.51s run time 
#x1B[1m#x1B[.../api/endpoints/test_organization_auth_tokens.py#x1B[0m:202: in test_manager_can_get
    self.assert_manager_can_access(self.path)
#x1B[1m#x1B[.../sentry/testutils/cases.py#x1B[0m:939: in assert_manager_can_access
    return self.assert_role_can_access(path, "manager", **kwargs)
#x1B[1m#x1B[.../sentry/testutils/cases.py#x1B[0m:960: in assert_role_can_access
    return self.assert_can_access(user, path, **kwargs)
#x1B[1m#x1B[.../sentry/testutils/cases.py#x1B[0m:926: in assert_can_access
    resp = getattr(self.client, method.lower())(path, **kwargs)
#x1B[1m#x1B[31m.venv/lib/python3.13.../django/test/client.py#x1B[0m:1129: in get
    response = super().get(
#x1B[1m#x1B[31m.venv/lib/python3.13.../django/test/client.py#x1B[0m:479: in get
    return self.generic(
#x1B[1m#x1B[31m.venv/lib/python3.13.../django/test/client.py#x1B[0m:676: in generic
    return self.request(**r)
#x1B[1m#x1B[31m.venv/lib/python3.13.../django/test/client.py#x1B[0m:1092: in request
    self.check_exception(response)
#x1B[1m#x1B[31m.venv/lib/python3.13.../django/test/client.py#x1B[0m:805: in check_exception
    raise exc_value
#x1B[1m#x1B[31m.venv/lib/python3.13.../core/handlers/exception.py#x1B[0m:55: in inner
    response = get_response(request)
#x1B[1m#x1B[31m.venv/lib/python3.13.../core/handlers/base.py#x1B[0m:197: in _get_response
    response = wrapped_callback(request, *callback_args, **callback_kwargs)
#x1B[1m#x1B[31m.venv/lib/python3.13.../views/decorators/csrf.py#x1B[0m:65: in _view_wrapper
    return view_func(request, *args, **kwargs)
#x1B[1m#x1B[31m.venv/lib/python3.13.../views/generic/base.py#x1B[0m:104: in view
    return self.dispatch(request, *args, **kwargs)
#x1B[1m#x1B[.../sentry/silo/base.py#x1B[0m:158: in override
    return original_method(*args, **kwargs)
#x1B[1m#x1B[31m.venv/lib/python3.13.../views/decorators/csrf.py#x1B[0m:65: in _view_wrapper
    return view_func(request, *args, **kwargs)
#x1B[1m#x1B[.../sentry/api/base.py#x1B[0m:119: in allow_cors_options_wrapper
    response = func(self, request, *args, **kwargs)
#x1B[1m#x1B[.../sentry/api/base.py#x1B[0m:473: in dispatch
    raise MissingPaginationError(handler.__func__.__qualname__)
#x1B[1m#x1B[31mE   sentry.api.paginator.MissingPaginationError: Response is not paginated correctly in OrganizationAuthTokensEndpoint.get.#x1B[0m
#x1B[1m#x1B[31mE                       List API response should be paginated, as lack of pagination can break the product in the future due to eventual growth.#x1B[0m
#x1B[1m#x1B[31mE                       Learn more about pagination in https://develop.sentry.dev/api/concepts/#paginating-responses and reach out to #discuss-api if you have any questions.#x1B[0m
tests.sentry.api.endpoints.test_organization_auth_tokens.OrganizationAuthTokensPermissionTest::test_member_can_get
Stack Traces | 4.5s run time 
#x1B[1m#x1B[.../api/endpoints/test_organization_auth_tokens.py#x1B[0m:205: in test_member_can_get
    self.assert_member_can_access(self.path)
#x1B[1m#x1B[.../sentry/testutils/cases.py#x1B[0m:936: in assert_member_can_access
    return self.assert_role_can_access(path, "member", **kwargs)
#x1B[1m#x1B[.../sentry/testutils/cases.py#x1B[0m:960: in assert_role_can_access
    return self.assert_can_access(user, path, **kwargs)
#x1B[1m#x1B[.../sentry/testutils/cases.py#x1B[0m:926: in assert_can_access
    resp = getattr(self.client, method.lower())(path, **kwargs)
#x1B[1m#x1B[31m.venv/lib/python3.13.../django/test/client.py#x1B[0m:1129: in get
    response = super().get(
#x1B[1m#x1B[31m.venv/lib/python3.13.../django/test/client.py#x1B[0m:479: in get
    return self.generic(
#x1B[1m#x1B[31m.venv/lib/python3.13.../django/test/client.py#x1B[0m:676: in generic
    return self.request(**r)
#x1B[1m#x1B[31m.venv/lib/python3.13.../django/test/client.py#x1B[0m:1092: in request
    self.check_exception(response)
#x1B[1m#x1B[31m.venv/lib/python3.13.../django/test/client.py#x1B[0m:805: in check_exception
    raise exc_value
#x1B[1m#x1B[31m.venv/lib/python3.13.../core/handlers/exception.py#x1B[0m:55: in inner
    response = get_response(request)
#x1B[1m#x1B[31m.venv/lib/python3.13.../core/handlers/base.py#x1B[0m:197: in _get_response
    response = wrapped_callback(request, *callback_args, **callback_kwargs)
#x1B[1m#x1B[31m.venv/lib/python3.13.../views/decorators/csrf.py#x1B[0m:65: in _view_wrapper
    return view_func(request, *args, **kwargs)
#x1B[1m#x1B[31m.venv/lib/python3.13.../views/generic/base.py#x1B[0m:104: in view
    return self.dispatch(request, *args, **kwargs)
#x1B[1m#x1B[.../sentry/silo/base.py#x1B[0m:158: in override
    return original_method(*args, **kwargs)
#x1B[1m#x1B[31m.venv/lib/python3.13.../views/decorators/csrf.py#x1B[0m:65: in _view_wrapper
    return view_func(request, *args, **kwargs)
#x1B[1m#x1B[.../sentry/api/base.py#x1B[0m:119: in allow_cors_options_wrapper
    response = func(self, request, *args, **kwargs)
#x1B[1m#x1B[.../sentry/api/base.py#x1B[0m:473: in dispatch
    raise MissingPaginationError(handler.__func__.__qualname__)
#x1B[1m#x1B[31mE   sentry.api.paginator.MissingPaginationError: Response is not paginated correctly in OrganizationAuthTokensEndpoint.get.#x1B[0m
#x1B[1m#x1B[31mE                       List API response should be paginated, as lack of pagination can break the product in the future due to eventual growth.#x1B[0m
#x1B[1m#x1B[31mE                       Learn more about pagination in https://develop.sentry.dev/api/concepts/#paginating-responses and reach out to #discuss-api if you have any questions.#x1B[0m

To view more test analytics, go to the Test Analytics Dashboard
📢 Thoughts on this report? Let us know!

@evanpurkhiser evanpurkhiser force-pushed the evanpurkhiser/ref-py-move-org-organization-auth-tokens branch from 5caf088 to 1e11bb4 Compare January 17, 2025 21:10
@evanpurkhiser evanpurkhiser merged commit 21a79d4 into master Jan 17, 2025
47 checks passed
@evanpurkhiser evanpurkhiser deleted the evanpurkhiser/ref-py-move-org-organization-auth-tokens branch January 17, 2025 21:37
andrewshie-sentry pushed a commit that referenced this pull request Jan 22, 2025
@evanpurkhiser @andrewshie-sentry
ref(py): Move {org -> organization}_auth_tokens (#83677)
fdac79a
@github-actions github-actions bot locked and limited conversation to collaborators Feb 2, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JoshFerge JoshFerge JoshFerge approved these changes

@wedamija wedamija wedamija approved these changes

Assignees
No one assigned
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@evanpurkhiser @JoshFerge @wedamija