fix(widget-builder): Clear sorting on field and y-axis changes #83679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sorting isn't necessary when you don't have a grouping, so update the state to set a default when a grouping is added (with priority for the yAxis if it exists) and clear the sort if a yAxis changes and a grouping is not applied.
github-actions
bot
added
the
Scope: Frontend
nikkikapadia
approved these changes
Jan 17, 2025
| if ( | ||
| displayType !== DisplayType.TABLE && | ||
| displayType !== DisplayType.BIG_NUMBER && | ||
| action.payload.length > 0 |
There was a problem hiding this comment.
just wondering if this gets into the state that it is 0 should we clear the sort completely? My brain is also fried rn so ignore if the answer to this is very obvious 😭
There was a problem hiding this comment.
With the endpoint, it's fine if there's a sort and no grouping as long as the sort is one of the other fields (e.g. aggregates)... I'm inclined to keep it because it works a bit more nicely with the default queries at the moment! Although you are right, eventually it's probably cleaner to just remove it and acknowledge that it's not really doing anything
narsaynorath
deleted the
nar/fix/widget-builder-clear-sorting-on-field-and-yaxis-changes
branch
andrewshie-sentry
pushed a commit
that referenced
this pull request
Jan 22, 2025
Sorting isn't necessary when you don't have a grouping, so update the state to set a default when a grouping is added (with priority for the yAxis if it exists) and clear the sort if a yAxis changes and a grouping is not applied.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorting isn't necessary when you don't have a grouping, so update the state to set a default when a grouping is added (with priority for the yAxis if it exists) and clear the sort if a yAxis changes and a grouping is not applied.