chore(eslint): Enable eslint rules that overlap with biome #83694
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
scttcper
approved these changes
Jan 21, 2025
andrewshie-sentry
pushed a commit
that referenced
this pull request
Jan 22, 2025
A little followup to #83693 This enables 3 rules from biome that are implemented in eslint as part of this plugin. This plugin has a lot of rules, the recommended set is too opinionated, but a handful would be nice to enable inside sentry. I'll make a list with TODO comments as a followup, and then work against that list rule by rule in followup PRs. For now we just need to pluck these three rules to match what's already happening.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A little followup to #83693
This enables 3 rules from biome that are implemented in eslint as part of this plugin.
This plugin has a lot of rules, the recommended set is too opinionated, but a handful would be nice to enable inside sentry. I'll make a list with TODO comments as a followup, and then work against that list rule by rule in followup PRs. For now we just need to pluck these three rules to match what's already happening.