Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enha: use SentryWidget in Flutter onboarding #83697

Merged
merged 1 commit into from
Jan 27, 2025

Conversation

vaind
Copy link
Contributor

@vaind vaind commented Jan 19, 2025

SentryWidget is necessary for some of the Flutter SDK features. People should be better guided to set them up when adding Sentry to their app.

Part of getsentry/sentry-dart#2562
Related: getsentry/sentry-docs#12390

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Jan 19, 2025
@vaind vaind marked this pull request as ready for review January 19, 2025 15:48
@vaind vaind requested a review from a team as a code owner January 19, 2025 15:48
@kahest kahest requested a review from buenaflor January 20, 2025 09:39
@priscilawebdev priscilawebdev added the Trigger: getsentry tests Once code is reviewed: apply label to PR to trigger getsentry tests label Jan 27, 2025
Copy link
Member

@priscilawebdev priscilawebdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it looks good to me! Thanks for improving our flutter getting started doc @vaind 👏

@vaind
Copy link
Contributor Author

vaind commented Jan 27, 2025

Thanks @priscilawebdev
Can you also merge this? I don't have write access in this repo.

@priscilawebdev priscilawebdev merged commit ee7a0e1 into getsentry:master Jan 27, 2025
42 of 44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Frontend Automatically applied to PRs that change frontend components Trigger: getsentry tests Once code is reviewed: apply label to PR to trigger getsentry tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants