fix(insights): Close span samples panel when navigating to a trace view #83699
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- close panel unless _all_ required params are present - close panel if landing on the trace view
github-actions
bot
added
the
Scope: Frontend
DominikB2014
approved these changes
Jan 20, 2025
gggritso
deleted the
fix/insights/close-samples-panel-when-viewing-sample
branch
andrewshie-sentry
pushed a commit
that referenced
this pull request
Jan 22, 2025
…ew (#83699) Right now, clicking on a span ID in the panel keeps the panel open, and navigates to the trace view. Closing the panel then calls the `onClose` callback, and sometimes clobbers the URL. Navigating to the sample view should close the panel, this PR adds that check. This is a hotfix, the proper solution is to make the navigation behaviour more robust, probably by rendering the panel view at a `/samples/` sub-route, which is easier to detect on navigation.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now, clicking on a span ID in the panel keeps the panel open, and navigates to the trace view. Closing the panel then calls the
onClosecallback, and sometimes clobbers the URL.Navigating to the sample view should close the panel, this PR adds that check. This is a hotfix, the proper solution is to make the navigation behaviour more robust, probably by rendering the panel view at a
/samples/sub-route, which is easier to detect on navigation.