ref(integrations): Decouple getting trees and code mapping #83705
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the ground work for other source code integrations to supporting searching for a file in the organization's SCM.
github-actions
bot
added
Scope: Frontend
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #83705 +/- ##
===========================================
+ Coverage 51.82% 87.57% +35.74%
===========================================
Files 9554 9546 -8
Lines 541207 541401 +194
Branches 21331 21260 -71
===========================================
+ Hits 280485 474120 +193635
+ Misses 260367 66926 -193441
Partials 355 355 |
Bundle ReportChanges will increase total bundle size by 3.49kB (0.01%) ⬆️. This is within the configured threshold ✅ Detailed changes
|
armenzg
commented
Jan 21, 2025
| @@ -30,6 +30,7 @@ | |||
| from sentry.integrations.models.organization_integration import OrganizationIntegration | |||
| from sentry.integrations.services.repository import RpcRepository, repository_service | |||
| from sentry.integrations.source_code_management.commit_context import CommitContextIntegration | |||
| from sentry.integrations.source_code_management.repo_trees import RepoTreesIntegration | |||
There was a problem hiding this comment.
RepoTreesIntegration will contain much code from the GitHub client without GitHub specific code.
There was a problem hiding this comment.
The code removed from this module belongs to getting the repo trees rather than creating the code mappings.
|
Thanks @GabeVillalobos ! In response to Josh's comment. I spoke with him on Slack. I will merge this tomorrow. |
armenzg
added a commit
that referenced
this pull request
Jan 28, 2025
In #83705 we created a client which is not strongly coupled with the GitHub client. This change removes the old code.
armenzg
added a commit
that referenced
this pull request
Jan 28, 2025
In #83705 we created a client which is not strongly coupled with the GitHub client. This change removes the old code.
armenzg
added a commit
that referenced
this pull request
Jan 29, 2025
In #83705 we created a client not strongly coupled with the GitHub client. This change removes the old code.
andrewshie-sentry
pushed a commit
that referenced
this pull request
Jan 29, 2025
The code to getting trees for repos (required for deriving code mappings) is strongly coupled with the GitHub client, thus, requiring making it hard to expand the feature to other integrations (upcoming work by the Ecosystem team). This makes the logic independent from the GitHub client. An option will control which code path to use, thus, a follow-up change will be required to deprecate the old code.
andrewshie-sentry
pushed a commit
that referenced
this pull request
Jan 29, 2025
In #83705 we created a client not strongly coupled with the GitHub client. This change removes the old code.
c298lee
pushed a commit
that referenced
this pull request
Jan 29, 2025
The code to getting trees for repos (required for deriving code mappings) is strongly coupled with the GitHub client, thus, requiring making it hard to expand the feature to other integrations (upcoming work by the Ecosystem team). This makes the logic independent from the GitHub client. An option will control which code path to use, thus, a follow-up change will be required to deprecate the old code.
c298lee
pushed a commit
that referenced
this pull request
Jan 29, 2025
In #83705 we created a client not strongly coupled with the GitHub client. This change removes the old code.
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
armenzg
removed
the
Scope: Frontend
armenzg
added a commit
that referenced
this pull request
Jan 31, 2025
andrewshie-sentry
pushed a commit
that referenced
this pull request
Feb 5, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code to getting trees for repos (required for deriving code mappings) is strongly coupled with the GitHub client, thus, requiring making it hard to expand the feature to other integrations (upcoming work by the Ecosystem team).
This makes the logic independent from the GitHub client.
An option will control which code path to use, thus, a follow-up change will be required to deprecate the old code.