-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(issues): add feature flags to issue stream search suggestions #83968
Merged
Merged
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
726447d
Init (needs backend flags[*] support)
aliu39 2bb5166
Add FieldKind and rename flag[] -> flags[]
aliu39 0a3ef26
Merge optimization
aliu39 ad9873a
Prioritize tag suggestion (undos flags[] approach)
aliu39 6e45f36
Show bool type when hovering over a flag suggestion
aliu39 8a300de
Gate both key/val queries with feature flag
aliu39 b9231dc
Merge branch 'master' of github.com:getsentry/sentry into aliu/ff-sea…
aliu39 8483546
Check ff in fetchFeatureFlagValues instead of callsite
aliu39 62c5fe8
Review comments
aliu39 ae6ed4f
Check if tag is ff before values query
aliu39 9dda463
Wrap flag keys with double quotes in useFetchIssueTags
aliu39 7d9abeb
Strip wrapping quotes before values query
aliu39 2bb1bc9
Merge branch 'master' of github.com:getsentry/sentry into aliu/ff-sea…
aliu39 1c12c81
Merge branch 'master' of github.com:getsentry/sentry into aliu/ff-sea…
aliu39 26caf1b
Review comments - only wrap if contains ':', only unwrap if FF
aliu39 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is questionable to me because tags could have colons too but its fine we're not breaking something. We could always extend this later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good, @malwilley specifically requested this just to be safe, so the changes are FF only
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I asked for this to be added because there's a risk that this new stripping logic might interfere with existing tags. Agree that the final solution should be generic