feat(nav): duplicate profiling/traces/replays/discover/releases routes under /explore #84262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
❌ 1 Tests Failed:
View the top 1 failed tests by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
scttcper
reviewed
Jan 30, 2025
static/app/routes.tsx
Outdated
| </Route> | ||
| ); | ||
|
|
||
| const exploreRoutes = ( | ||
| <Route | ||
| path="/explore/" | ||
| path="/explore" |
There was a problem hiding this comment.
this looks wrong. but maybe because there's no index route?
There was a problem hiding this comment.
Ah yeah you're right should have a / at the end
scttcper
approved these changes
Jan 30, 2025
andrewshie-sentry
pushed a commit
that referenced
this pull request
Feb 5, 2025
…s under /explore (#84262) The following products will live under the `/explore/` URL structure (once the new nav is complete): - Profiling - Traces - Replays - Discover - Releases In this PR I am simply duplicating the existing routes under `/explore/` so that going to `/explore/replays` will render the same thing that `/replays/` does. In the future we will also need to add redirects and change the existing links to the new structure.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #84018
The following products will live under the
/explore/URL structure (once the new nav is complete):In this PR I am simply duplicating the existing routes under
/explore/so that going to/explore/replayswill render the same thing that/replays/does. In the future we will also need to add redirects and change the existing links to the new structure.