Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cleanup): Use correct expiration thresholds for API model cleanup #85572

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

fix(cleanup): Use correct expiration thresholds for API model cleanup #85572

wants to merge 1 commit into from

Conversation

mdtro
Copy link
Member

@mdtro mdtro commented Feb 20, 2025

Pulled from #82052 to break out these changes into smaller PRs.

  • Update delete_api_models to use model-specific DEFAULT_EXPIRATION values
  • Use API_GRANT_EXPIRATION for ApiGrant and API_TOKEN_EXPIRATION for ApiToken
  • Fix potential over-deletion of valid tokens

@mdtro
fix(cleanup): Use correct expiration thresholds for API model cleanup
20de351 
- Update delete_api_models to use model-specific DEFAULT_EXPIRATION values
- Use API_GRANT_EXPIRATION for ApiGrant and API_TOKEN_EXPIRATION for ApiToken
- Fix potential over-deletion of valid tokens
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Feb 20, 2025
@mdtro mdtro requested a review from a team February 20, 2025 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mdtro