ref(uptime): Use detectorId for uptime rules on the frontend #98527
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
evanpurkhiser
commented
Aug 29, 2025
Comment on lines
+17
to
+20
| // TODO(epurkhiser): We need a better way to query for uptime issues, using | ||
| // the title is brittle and means when the user changes the URL we'll have to | ||
| // wait for a new event before the issue matches again. | ||
| const query = `issue.type:${IssueType.UPTIME_DOMAIN_FAILURE} title:"Downtime detected for ${uptimeRule.url}"`; |
There was a problem hiding this comment.
This is probably the most egregious change. We'll need to figure out a better way to query for issues associated to the uptime detectors.
There was a problem hiding this comment.
Hmm there was work done to get the query detector:<detector_id> working, but as I'm testing it now that doesn't appear to work. I'll look into that and make sure that gets fixed, then we can switch this over to use that instead.
This was the original PR for that #95515
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Updates all uptime components and utilities to use detectorId instead of uptimeRuleId/projectUptimeSubscriptionId. - Update API endpoints to use `detectorId` with `useDetectorId` query param - Migrate event occurrence data to use `detectorId` from `evidenceData` - Update route params from `uptimeRuleId` to `detectorId` - Refactor all hooks and utilities to use `detectorId` parameter - Update tests to reflect new `detectorId` structure - Moves delete functionality to uptime action creators
evanpurkhiser
force-pushed
the
evanpurkhiser/ref-uptime-use-detectorid-for-uptime-rules-on-the-frontend
branch
from
e45045b to
676babc
Compare
evanpurkhiser
added a commit
that referenced
this pull request
Aug 29, 2025
We no longer need support for querying by projectUptimeSubscriptionId Requires #98527
malwilley
approved these changes
Sep 2, 2025
Comment on lines
+17
to
+20
| // TODO(epurkhiser): We need a better way to query for uptime issues, using | ||
| // the title is brittle and means when the user changes the URL we'll have to | ||
| // wait for a new event before the issue matches again. | ||
| const query = `issue.type:${IssueType.UPTIME_DOMAIN_FAILURE} title:"Downtime detected for ${uptimeRule.url}"`; |
There was a problem hiding this comment.
Hmm there was work done to get the query detector:<detector_id> working, but as I'm testing it now that doesn't appear to work. I'll look into that and make sure that gets fixed, then we can switch this over to use that instead.
This was the original PR for that #95515
evanpurkhiser
deleted the
evanpurkhiser/ref-uptime-use-detectorid-for-uptime-rules-on-the-frontend
branch
evanpurkhiser
added a commit
that referenced
this pull request
Sep 4, 2025
This systemically removes ProjectUptimeSubscription usages from uptime endpoints. - Remove legacy dual ID handling logic and query parameter dependencies. The useDetectorId query parameter no longer has any affect, all IDs are treated as detector Ids. - Update all endpoints to use Detector model instead of ProjectUptimeSubscription. - Refactor serializers to work with Detector objects and associated UptimeSubscription data. - Update validators to create and update Detector instances directly - Update audit logging to use detector IDs and consolidated audit log data functions. Previously the get_audit_log_data method was part of the ProjectUptimeSubscription, which is no longer used. - Remove unused ProjectUptimeSubscription references throughout codebase IMPORTANTLY the tests have very little changes to them, this is because this change does NOT change how data is returned. Requires #98527
evanpurkhiser
added a commit
that referenced
this pull request
Sep 4, 2025
This systemically removes ProjectUptimeSubscription usages from uptime endpoints. - Remove legacy dual ID handling logic and query parameter dependencies. The useDetectorId query parameter no longer has any affect, all IDs are treated as detector Ids. - Update all endpoints to use Detector model instead of ProjectUptimeSubscription. - Refactor serializers to work with Detector objects and associated UptimeSubscription data. - Update validators to create and update Detector instances directly - Update audit logging to use detector IDs and consolidated audit log data functions. Previously the get_audit_log_data method was part of the ProjectUptimeSubscription, which is no longer used. - Remove unused ProjectUptimeSubscription references throughout codebase IMPORTANTLY the tests have very little changes to them, this is because this change does NOT change how data is returned. Requires #98527
evanpurkhiser
added a commit
that referenced
this pull request
Sep 4, 2025
This systemically removes ProjectUptimeSubscription usages from uptime endpoints. - Remove legacy dual ID handling logic and query parameter dependencies. The useDetectorId query parameter no longer has any affect, all IDs are treated as detector Ids. - Update all endpoints to use Detector model instead of ProjectUptimeSubscription. - Refactor serializers to work with Detector objects and associated UptimeSubscription data. - Update validators to create and update Detector instances directly - Update audit logging to use detector IDs and consolidated audit log data functions. Previously the get_audit_log_data method was part of the ProjectUptimeSubscription, which is no longer used. - Remove unused ProjectUptimeSubscription references throughout codebase IMPORTANTLY the tests have very little changes to them, this is because this change does NOT change how data is returned. Requires #98527
evanpurkhiser
added a commit
that referenced
this pull request
Sep 4, 2025
This systemically removes ProjectUptimeSubscription usages from uptime endpoints. - Remove legacy dual ID handling logic and query parameter dependencies. The useDetectorId query parameter no longer has any affect, all IDs are treated as detector Ids. - Update all endpoints to use Detector model instead of ProjectUptimeSubscription. - Refactor serializers to work with Detector objects and associated UptimeSubscription data. - Update validators to create and update Detector instances directly - Update audit logging to use detector IDs and consolidated audit log data functions. Previously the get_audit_log_data method was part of the ProjectUptimeSubscription, which is no longer used. - Remove unused ProjectUptimeSubscription references throughout codebase IMPORTANTLY the tests have very little changes to them, this is because this change does NOT change how data is returned. Requires #98527
evanpurkhiser
added a commit
that referenced
this pull request
Sep 4, 2025
This systemically removes ProjectUptimeSubscription usages from uptime endpoints. - Remove legacy dual ID handling logic and query parameter dependencies. The useDetectorId query parameter no longer has any affect, all IDs are treated as detector Ids. - Update all endpoints to use Detector model instead of ProjectUptimeSubscription. - Refactor serializers to work with Detector objects and associated UptimeSubscription data. - Update validators to create and update Detector instances directly - Update audit logging to use detector IDs and consolidated audit log data functions. Previously the get_audit_log_data method was part of the ProjectUptimeSubscription, which is no longer used. - Remove unused ProjectUptimeSubscription references throughout codebase IMPORTANTLY the tests have very little changes to them, this is because this change does NOT change how data is returned. Requires #98527
evanpurkhiser
added a commit
that referenced
this pull request
Sep 4, 2025
This systemically removes ProjectUptimeSubscription usages from uptime endpoints. - Remove legacy dual ID handling logic and query parameter dependencies. The useDetectorId query parameter no longer has any affect, all IDs are treated as detector Ids. - Update all endpoints to use Detector model instead of ProjectUptimeSubscription. - Refactor serializers to work with Detector objects and associated UptimeSubscription data. - Update validators to create and update Detector instances directly - Update audit logging to use detector IDs and consolidated audit log data functions. Previously the get_audit_log_data method was part of the ProjectUptimeSubscription, which is no longer used. - Remove unused ProjectUptimeSubscription references throughout codebase IMPORTANTLY the tests have very little changes to them, this is because this change does NOT change how data is returned. Requires #98527
armenzg
pushed a commit
that referenced
this pull request
Sep 5, 2025
Updates all uptime components and utilities to use detectorId instead of uptimeRuleId/projectUptimeSubscriptionId. - Update API endpoints to use `detectorId` with `useDetectorId` query param - Migrate event occurrence data to use `detectorId` from `evidenceData` - Update route params from `uptimeRuleId` to `detectorId` - Refactor all hooks and utilities to use `detectorId` parameter - Update tests to reflect new `detectorId` structure - Moves delete functionality to uptime action creators
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates all uptime components and utilities to use detectorId instead
of uptimeRuleId/projectUptimeSubscriptionId.
detectorIdwithuseDetectorIdquery paramdetectorIdfromevidenceDatauptimeRuleIdtodetectorIddetectorIdparameterdetectorIdstructure