feat(checkout v3): Full screen #98540
Merged
+310
−220
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Comment on lines
129
to
131
| browserHistory.push(`/settings/${props.organization.slug}/billing/checkout/`); | ||
| } else if (!props.location?.pathname.includes('checkout-v3') && props.isNewCheckout) { | ||
| browserHistory.push(`/checkout-v3/`); |
There was a problem hiding this comment.
i have a backlog ticket to refactor this component to FC so we can use useNavigate, but until then i'm not sure if there's anything we can use beyond browserHistory
static/gsApp/hooks/rootRoutes.tsx
Outdated
| children: [ | ||
| { | ||
| index: true, | ||
| component: make(() => import('../views/decideCheckout')), |
There was a problem hiding this comment.
nit: use absolute path here
|
Billing LGTM |
JonasBa
reviewed
Sep 5, 2025
JonasBa
reviewed
Sep 5, 2025
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
❌ 13 Tests Failed:
View the top 3 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
JonasBa
approved these changes
Sep 5, 2025
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
on small screens:
on very large screens, we center the content:
