Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref: Remove python replays processor #5672

Merged
merged 5 commits into from
Jan 8, 2025
Merged

ref: Remove python replays processor #5672

merged 5 commits into from
Jan 8, 2025

Conversation

lynnagara
Copy link
Member

This is rust now

@lynnagara lynnagara requested a review from a team as a code owner March 19, 2024 22:50
Copy link

codecov bot commented Jan 7, 2025

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
1 1 0 0
View the top 1 failed tests by shortest run time
::tests.datasets.test_replays_processor
Stack Traces | 0s run time
ImportError while importing test module '.../tests/datasets/test_replays_processor.py'.
Hint: make sure your test modules/packages have valid Python names.
Traceback:
.../local/lib/python3.11.../site-packages/_pytest/python.py:608: in _importtestmodule
    mod = import_path(self.path, mode=importmode, root=self.config.rootpath)
.../local/lib/python3.11.../site-packages/_pytest/pathlib.py:533: in import_path
    importlib.import_module(module_name)
.../local/lib/python3.11/importlib/__init__.py:126: in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
<frozen importlib._bootstrap>:1204: in _gcd_import
    ???
<frozen importlib._bootstrap>:1176: in _find_and_load
    ???
<frozen importlib._bootstrap>:1147: in _find_and_load_unlocked
    ???
<frozen importlib._bootstrap>:690: in _load_unlocked
    ???
.../local/lib/python3.11.../_pytest/assertion/rewrite.py:168: in exec_module
    exec(co, module.__dict__)
tests/datasets/test_replays_processor.py:12: in <module>
    from snuba.datasets.processors.replays_processor import (
E   ImportError: cannot import name 'maybe' from 'snuba.datasets.processors.replays_processor' (.../datasets/processors/replays_processor.py)

To view more test analytics, go to the Test Analytics Dashboard
📢 Thoughts on this report? Let us know!

@cmanallen
Copy link
Member

I removed the Python test suite. It wasn't testing anything except the rust processor and that has rust test coverage.

@untitaker untitaker enabled auto-merge (squash) January 8, 2025 16:32
@untitaker untitaker merged commit 06a6865 into master Jan 8, 2025
31 checks passed
@untitaker untitaker deleted the replays-processor branch January 8, 2025 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants