-
-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(admin): add example RPC call for the endpoints missing it #6615
Conversation
❌ 1 Tests Failed:
View the top 1 failed tests by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
Make sure you test these when it gets deployed, should be easily runnable in prod |
LGTM, thanks for fixing it. I am wondering if it is possible to automate the request body creation by writing a python script using |
@onkar I like that idea, I think that would be good |
ff38c5a
to
c4f10c9
Compare
this closes https://github.com/getsentry/eap-planning/issues/98
I added an example request to each of the following endpoints that were missing it.
used to look like
now it looks like
I got the example request for each endpoint from one of its unit tests, I tried to pick a basic representative one. Here are all the endpoints I added example requests for, and a link to the test that I got the request from:
All the new example RPC calls successfully send except for CreateSubscriptionRequest.
It has a 400 error due to no meta field:
This is a bug that has been revealed by this PR but is unrelated to it so I plan to solve this as a follow up in a separate PR. #6617
The PR diff makes it look like the entire file changed but thats just bc I ran a formatter on the JSON. Actually the only real changes are the additions from line 87 to the end.