protubuf comparisons

[xurui-c]

During the investigation of https://github.com/getsentry/eap-planning/issues/117, we realized that comparing protobuf objects containing floats does not run into floating point precision errors; however, extracting the floats fields out and comparing them does.

In test_single_float_comparison, we demonstrate that the value (0.123456) that we send to RPC is exactly the value we get back - no floating point precision errors

[codecov]

❌ 1 Tests Failed:

Tests completed	Failed	Passed	Skipped
2745	1	2744	5

View the top 1 failed tests by shortest run time

tests.web.rpc.v1.test_endpoint_trace_item_table.test_endpoint_trace_item_table.TestTraceItemTable::test_rounding

Stack Traces | 0.277s run time

Traceback (most recent call last):
  File ".../v1/test_endpoint_trace_item_table/test_endpoint_trace_item_table.py", line 1062, in test_rounding
    assert result.column_values[0].results[0].val_float == 0.475
AssertionError: assert 0.4749999940395355 == 0.475
 +  where 0.4749999940395355 = val_float: 0.475\n.val_float

To view more test analytics, go to the Test Analytics Dashboard
📢 Thoughts on this report? Let us know!