ref(admin): Switch to esbuild #6700
Merged
+436
−664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
webpack takes more than a minute, esbuild takes 2 seconds. esbuild has reasonable defaults wrt building css imports, webpack needs two additional plugins for that. esbuild has no file-watching support, but node has. since the build is now fast, we can just do a full rebuild when any file changes. there are other, newer, cooler runtimes (bun, rome, biome, idk), but esbuild has not changed in the past 2 years and is the one I know.
untitaker
commented
Dec 23, 2024
| @@ -19,4 +19,6 @@ else | |||
| unset PS1 | |||
| fi | |||
|
|
|||
| export PATH="$PWD/snuba/admin/node_modules/.bin/:$PATH" | |||
There was a problem hiding this comment.
not necessary and unrelated to this switch. being able to run jest directly is nice
onkar
approved these changes
Dec 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
webpack takes
more than a minute30s, esbuild takes 2 seconds. esbuild hasreasonable defaults wrt building css imports, webpack needs two
additional plugins for that.
esbuild has no file-watching support, but node has. since the build is
now fast, we can just do a full rebuild when any file changes.
there are other, newer, cooler runtimes (bun, rome, biome, idk), but
esbuild has not changed in the past 2 years and is the one I know.