Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve internal error logging for rpc endpoints #6703

Merged
merged 1 commit into from
Dec 31, 2024

Conversation

kylemumma
Copy link
Member

@kylemumma kylemumma commented Dec 27, 2024

I believe that when internal errors happen in our RPC endpoints, its not currently logged to sentry. This is bc internal errors are caught, translated into error protobufs, and sent back as a 500 response. Since the exceptions are caught they must be logged explicitly, thats what this PR does.

extra, optional:
https://sentry.sentry.io/performance/trace/a8133bb3ddb340deb9dab4dbbf912fe4/?node=txn-7d11c149497d4bd284d4bfe0d9173608&pageEnd=2024-12-28T07%3A43%3A21.936&pageStart=2024-12-27T07%3A43%3A21.936&timestamp=1735328601.721
you can see in this error trace that sentry gets a 500 internal error from snuba, but there is no associated snuba error logged

@kylemumma kylemumma marked this pull request as ready for review December 27, 2024 21:35
@kylemumma kylemumma requested review from a team as code owners December 27, 2024 21:35
Copy link
Member

@colin-sentry colin-sentry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@kylemumma kylemumma merged commit 234ba79 into master Dec 31, 2024
31 checks passed
@kylemumma kylemumma deleted the krm/banana78 branch December 31, 2024 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants