Repository navigation
Conversation
dezzeddi
force-pushed
the
daniezzeddine/trace-item-filter-converter
branch
from
October 8, 2026 18:44
59ff718 to
2693ac7
Compare
Base automatically changed from
daniezzeddine/eap-797-improve-how-we-use-indexed-columns
to
master
October 8, 2026 19:07
dezzeddi
force-pushed
the
daniezzeddine/trace-item-filter-converter
branch
from
October 8, 2026 22:19
2693ac7 to
c19ee3e
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactors
trace_item_filters_to_expressioninto aTraceItemFilterConverterclass. No behaviour change.item_type,attribute_key_to_expression,membership_as_has,start_timestamp) live on the class instead of being passed through every recursive call.matchon the filter kind and comparison op replaces the longifchains, with one method per filter kind and per op._Comparison.from_filterbuilds a comparison's operands once for all op methods.trace_item_filters_to_expressionsignature is unchanged, so callers don't change.