Repository navigation
feat(symcache): Represent void* pointers in symcache - #1101
Open
szokeasaurusrex wants to merge 1 commit into
Open
szokeasaurusrex wants to merge 1 commit into
szokeasaurusrex wants to merge 1 commit into
Conversation
|
loewenheim
approved these changes
Oct 21, 2026
szokeasaurusrex
force-pushed
the
szokeasaurusrex/void-pointers-symcache
branch
2 times, most recently
from
October 21, 2026 14:23
2c52d62 to
e850a2d
Compare
szokeasaurusrex
marked this pull request as draft
October 22, 2026 08:47
Member
Author
|
Converting to draft as we update #1100 |
szokeasaurusrex
force-pushed
the
szokeasaurusrex/void-pointers-symcache
branch
from
October 23, 2026 09:03
e850a2d to
c4f5af6
Compare
szokeasaurusrex
marked this pull request as ready for review
October 23, 2026 09:13
szokeasaurusrex
force-pushed
the
szokeasaurusrex/void-pointers-symcache
branch
from
October 23, 2026 12:39
c4f5af6 to
3c58177
Compare
Now that `symbolic-debuginfo` supports resolving `void*` pointers via `PointerType::pointee` set to `None`, represent `void*` pointers in `symbolic-symcache` using a dedicated `Type::VOID` (`u32::MAX - 1`) sentinel for `pointee_idx`. This separates `void*` pointers (`PointerType::pointee() == None`) from pointers whose referenced type could not be resolved (`PointerType::pointee() == Some(id)` where `SymCache::lookup_type(id)` returns `None`). Closes #1099 Closes [SYMBOL-44](https://linear.app/getsentry/issue/SYMBOL-44)
szokeasaurusrex
force-pushed
the
szokeasaurusrex/void-pointers-symcache
branch
from
October 23, 2026 15:16
3c58177 to
f6c085c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now that
symbolic-debuginfosupports resolvingvoid*pointers viaPointerType::pointeeset toNone, representvoid*pointers insymbolic-symcacheusing a dedicatedType::VOID(u32::MAX - 1) sentinel forpointee_idx. This separatesvoid*pointers (PointerType::pointee() == None) from pointers whose referenced type could not be resolved (PointerType::pointee() == Some(id)whereSymCache::lookup_type(id)returnsNone).Closes #1099
Closes SYMBOL-44