fix(sourcemapcache): Tokens only extend to the end of the line #932
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the `sourcemapcache` equivalent of getsentry/rust-sourcemap#131 (but does not depend on it). Previously, when looking up a line and column, we would always return the token at or immediately before that position, even if it belonged to an earlier minified line. This is 1. wrong—tokens are only meant to extend to the end of a line. 2. inconsistent—this means that an unmapped line before any mapped line would return no mapping, but an unmapped line after a mapped line would.
loewenheim
force-pushed
the
sebastian/sourcemapcache-lookup-lines
branch
from
3511d14 to
11b97ea
Compare
Dav1dde
approved these changes
Aug 11, 2025
loewenheim
added a commit
to getsentry/symbolicator
that referenced
this pull request
Aug 12, 2025
This updates `symbolic` to 12.16.2 to get access to getsentry/symbolic#932. This doesn't require a cache version bump because only the lookup function changed, all cache contents stay the same.
loewenheim
added a commit
to getsentry/symbolicator
that referenced
this pull request
Aug 13, 2025
This updates `symbolic` to 12.16.2 to get access to getsentry/symbolic#932. This doesn't require a cache version bump because only the lookup function changed, all cache contents stay the same.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, when looking up a line and column, we would always return the token at or immediately before that position, even if it belonged to an earlier minified line. This is
would return no mapping, but an unmapped line after a mapped line
would.